Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

diff --git a/d2/11f1c9c0ae73474fa0c8b93377e97eee6f9a13 b/d2/11f1c9c0ae73474fa0c8b93377e97eee6f9a13
new file mode 100644 (file)
index 0000000..59d08d6
--- /dev/null
+++ b/d2/11f1c9c0ae73474fa0c8b93377e97eee6f9a13
@@ -0,0 +1,117 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E5C5431FBC\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:30:48 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8xBzQmuTLf2P for <notmuch@notmuchmail.org>;\r
+       Tue,  4 Feb 2014 02:30:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9D17B431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:30:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4E55B100033;\r
+       Tue,  4 Feb 2014 12:30:31 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general\r
+       refactoring\r
+In-Reply-To: <20140204005331.GQ14197@odin.tremily.us>\r
+References: <cover.1391424512.git.wking@tremily.us>\r
+       <m2ha8frjgg.fsf@guru.guru-group.fi>\r
+       <20140204005331.GQ14197@odin.tremily.us>\r
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 04 Feb 2014 12:30:30 +0200\r
+Message-ID: <m2fvnzp3uh.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Feb 2014 10:30:48 -0000\r
+\r
+On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+\r
+> On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote:\r
+>>     data['message-id-term'] =3D 'id:"{}"'.format(value)\r
+>> ValueError: zero length field name in format\r
+>\r
+> Oops, Python 2.6 still needs explicit indexes ('{0}', not '{}').  It's\r
+> an easy fix, so I'll queue it for v2.  You're still going to need\r
+> Python 2.7 or greater for collections.OrderedDict().  We could word\r
+> around that too, but do we really care about 2.6?  I don't expect that\r
+> the installed nmbug-status userbase is so large and backward that\r
+> upgrading to 2.7 will be that hard ;).  2.6 isn't even getting\r
+> security fixes anymore [1], so I think it's time to migrate :p.\r
+\r
+Probably not many cares about 2.6; I already use argparse and I can add\r
+that OrderedDict() too. Still {0} is easy enough to do :D. I am running\r
+this notmuch & nmbug in Scientific Linux 6.2 machine which has python 2.6\r
+-- and this is the only machine where I can review your nmbug-status\r
+changes ;)\r
+\r
+>>   File "devel/nmbug/nmbug-status", line 197, in _write_threads\r
+>>     ).format(**message_display_data))\r
+>>   File "/usr/lib64/python2.6/codecs.py", line 351, in write\r
+>>     data, consumed =3D self.encode(object, self.errors)\r
+>> UnicodeEncodeError: 'ascii' codec can't encode character u'\u017b' in\r
+>>   position 176: ordinal not in range(128)\r
+>\r
+> Hmm.  __future__'s unicode_literals should be giving us a Unicode\r
+> target, so I'm not sure why we'd have trouble injecting Unicode.  This\r
+> works fine for me on Python 2.7 and 3.3.  Maybe you just have a funky\r
+> encoding?  What is your:\r
+>\r
+>   $ locale\r
+>   LANG=3Den_US.UTF-8\r
+>   =E2=80=A6\r
+>   $ python -c 'import locale, sys; print(locale.getpreferredencoding() or=\r
+ sys.getdefaultencoding())'\r
+>   UTF-8\r
+\r
+LANG=3Den_US.UTF-8\r
+all other LC_* variables en_US.UTF-8 except\r
+LC_TIME=3Den_GB.utf8\r
+LC_ALL empty (naturally)\r
+\r
+python -c 'import locale; print(locale.getpreferredencoding())'\r
+UTF-8\r
+python -c 'import sys; print(sys.getdefaultencoding())'\r
+ascii\r
+\r
+\r
+anyway, if this doesn't resolve out and there is no resistance to require\r
+python 2.7 (that means from David) I can hack around this to get this\r
+reviewed.\r
+\r
+>\r
+> Cheers,\r
+> Trevor\r
+\r
+Tomi\r
+\r
+>\r
+> [1]: http://www.python.org/download/releases/2.6.9/\r