--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 18CA9431FC2\r
+ for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 01:34:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 1NPQ5qt6cz6U for <notmuch@notmuchmail.org>;\r
+ Wed, 29 Oct 2014 01:34:29 -0700 (PDT)\r
+Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id DBC1F431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 01:34:28 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail1.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XjOhy-0008Kb-2R; Wed, 29 Oct 2014 08:34:24 +0000\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XjOhx-0001Bh-Mv; Wed, 29 Oct 2014 08:34:21 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Avoid empty thread names if possible.\r
+In-Reply-To: <87oatnakqy.fsf@jhu.edu>\r
+References: <87oatnakqy.fsf@jhu.edu>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 29 Oct 2014 08:34:19 +0000\r
+Message-ID: <87tx2nuvec.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 1a4550a7ce54ec42d6da23d121094105 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 08:34:37 -0000\r
+\r
+\r
+Hi\r
+\r
+On Tue, 07 Oct 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:\r
+> Currently the thread is named based on either the oldest or newest\r
+> matching message (depending on the search order). If this message has\r
+> an empty subject, though, the thread will show up with an empty\r
+> subject in the search results. (See the thread starting with\r
+> `id:1412371140-21051-1-git-send-email-david@tethera.net` for an\r
+> example.)\r
+>\r
+> This patch changes the behavior to name based on the oldest/newest\r
+> matching non-empty subject. This is particularly helpful for patchsets.\r
+> If the only subjects are empty, the thread subject will still be empty.\r
+\r
+I approve of the change in the output but I am unsure about the\r
+implementation. It would be nice to have a clear rule about which\r
+subject is taken. Eg: \r
+\r
+ if sort is oldest first then it is the subject of the oldest\r
+ matching message with a non-empty subject. Similarly if sort\r
+ is newest first.\r
+\r
+Also, it would be nice if the implementation did not rely on what order\r
+we call _thread_add_matched_message on the matching messages in the\r
+thread. I think in some ways we already rely on the order (for the order\r
+of the author list), but if you want to rely on the order here I think\r
+it at least deserves a comment.\r
+\r
+>\r
+> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+> ---\r
+> lib/thread.cc | 6 ++++--\r
+> 1 file changed, 4 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/lib/thread.cc b/lib/thread.cc\r
+> index 8922403..ea10295 100644\r
+> --- a/lib/thread.cc\r
+> +++ b/lib/thread.cc\r
+> @@ -348,18 +348,20 @@ _thread_add_matched_message (notmuch_thread_t *thread,\r
+> {\r
+> time_t date;\r
+> notmuch_message_t *hashed_message;\r
+> + const char *cur_subject;\r
+> \r
+> date = notmuch_message_get_date (message);\r
+> + cur_subject = notmuch_thread_get_subject (thread);\r
+> \r
+> if (date < thread->oldest || ! thread->matched_messages) {\r
+> thread->oldest = date;\r
+> - if (sort == NOTMUCH_SORT_OLDEST_FIRST)\r
+> + if (sort == NOTMUCH_SORT_OLDEST_FIRST || strlen(cur_subject) == 0)\r
+> _thread_set_subject_from_message (thread, message);\r
+> }\r
+> \r
+> if (date > thread->newest || ! thread->matched_messages) {\r
+> thread->newest = date;\r
+> - if (sort != NOTMUCH_SORT_OLDEST_FIRST)\r
+> + if (sort != NOTMUCH_SORT_OLDEST_FIRST || strlen(cur_subject) == 0)\r
+> _thread_set_subject_from_message (thread, message);\r
+> }\r
+\r
+So looking at the above I think the oldest first gives the subject in\r
+my suggestion above (since the messages are supplied in oldest first\r
+order). But newest first may not: indeed if the subject starts out as\r
+something and becomes empty then this will set the subject empty and\r
+then leave it empty.\r
+\r
+(Note _thread_set_subject_from_message calls notmuch_message_get_header\r
+which returns an empty string "" if the subject line is empty or not\r
+present).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+> \r
+> -- \r
+> 2.1.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff