Re: [PATCH] emacs: add buttons for all multipart/related parts

diff --git a/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9 b/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9
new file mode 100644 (file)
index 0000000..17feb1f
--- /dev/null
+++ b/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9
@@ -0,0 +1,129 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1426F431FC0\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Sep 2013 10:14:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ktuiO3+Sz0q8 for <notmuch@notmuchmail.org>;\r
+       Sun,  1 Sep 2013 10:14:07 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D5F54431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Sep 2013 10:14:06 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VGBDu-0001xs-OC; Sun, 01 Sep 2013 18:14:05 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VGBDt-00078v-H4; Sun, 01 Sep 2013 18:14:01 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts\r
+In-Reply-To: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+References: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 01 Sep 2013 18:13:59 +0100\r
+Message-ID: <871u58lb1k.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: b43aa68e48acbff414177ce82b8a0f9e (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.6 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 01 Sep 2013 17:14:15 -0000\r
+\r
+\r
+On Fri, 16 Aug 2013, Istvan Marko <notmuch@kismala.com> wrote:\r
+> When text/html parts include images as multipart/related and the\r
+> text/plain alternative is used these images can be completely hidden\r
+> with no easy way to access them or even find out that they are there.\r
+>\r
+> Make notmuch-show-insert-part-multipart/related add buttons for all\r
+> parts, the first one visible the rest hidden.\r
+\r
+Hello\r
+\r
+This patch LGTM +1.\r
+\r
+It is a clear improvement anyway but would benefit from my fix for the\r
+bug this exposes\r
+id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com (or some\r
+alternative). I don't know if we want to push the two together or just\r
+push each as it gets reviewed.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+\r
+\r
+> ---\r
+>  emacs/notmuch-show.el | 4 ++++\r
+>  1 file changed, 4 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 82b70ba..20844f0 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."\r
+>  \r
+>      ;; Render the primary part.\r
+>      (notmuch-show-insert-bodypart msg (car inner-parts) depth)\r
+> +    ;; Add hidden buttons for the rest\r
+> +    (mapc (lambda (inner-part)\r
+> +        (notmuch-show-insert-bodypart msg inner-part depth t))\r
+> +      (cdr inner-parts))\r
+>  \r
+>      (when notmuch-show-indent-multipart\r
+>        (indent-rigidly start (point) 1)))\r
+> -- \r
+> 1.8.1.4\r
+>\r
+>\r
+>\r
+>\r
+> -- \r
+>      Istvan\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r