Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.
authorKarl Fogel <kfogel@red-bean.com>
Mon, 7 Jul 2014 17:35:54 +0000 (12:35 +1900)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:03:27 +0000 (10:03 -0800)
ec/6637d1e20127325f1e186c05814ea5202e2cdd [new file with mode: 0644]

diff --git a/ec/6637d1e20127325f1e186c05814ea5202e2cdd b/ec/6637d1e20127325f1e186c05814ea5202e2cdd
new file mode 100644 (file)
index 0000000..c359f89
--- /dev/null
@@ -0,0 +1,107 @@
+Return-Path: <kfogel@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 116AE431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  7 Jul 2014 10:36:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id egP7uknrAmKd for <notmuch@notmuchmail.org>;\r
+       Mon,  7 Jul 2014 10:35:58 -0700 (PDT)\r
+Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com\r
+       [209.85.223.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 49EBC431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  7 Jul 2014 10:35:58 -0700 (PDT)\r
+Received: by mail-ie0-f180.google.com with SMTP id tr6so2002221ieb.39\r
+       for <notmuch@notmuchmail.org>; Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to\r
+       :message-id:user-agent:mime-version:content-type\r
+       :content-transfer-encoding;\r
+       bh=huwzrMNlwIpyn7WZpuO57JTgY4ZWyiHK7VH63AOjLM4=;\r
+       b=JOF9BeWwjM/Z/lQfn0ffkR+2Kma0NDUSZbG18Xl4Z/gJNZTKmbKJyDZ+0u6QJaakMn\r
+       rOuDiznRXlV7wKT/7BqFg6qMfk9csLWF+6iEs8JzFpGsV4iPYDiPyAOQLFEQjsvO0wwO\r
+       Z2tFEjLeYEZPQy8jta66egufpfahf+ZpvcWmnW/B8ln9V52Bqu4dEU/UWHxXkYsF8dx6\r
+       wY2W1+GnRsWsqLm5ERoSep0S9LD8sf2nRQEEROpE8Ndl6B9SqjRSrtsT9na1QUuISdNp\r
+       1mjOsgB+rzUw1yX14XWqKNH2R1V6/HFzhEUM4Ha7ww+m4peAFw/5Xf/0rLG9nFPllSgE\r
+       2hfQ==\r
+X-Received: by 10.42.104.75 with SMTP id q11mr33902844ico.35.1404754556839;\r
+       Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
+Received: from ktab.red-bean.com\r
+       (74-92-190-113-Illinois.hfc.comcastbusiness.net. [74.92.190.113])\r
+       by mx.google.com with ESMTPSA id t1sm91837123igh.9.2014.07.07.10.35.55\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
+Sender: Karl Fogel <kfogel@gmail.com>\r
+From: Karl Fogel <kfogel@red-bean.com>\r
+To: Sebastian Lipp <bacuh@riseup.net>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+       notmuch-address.el.\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi> <87vc7vgbym.fsf@zancas.localnet>\r
+       <m2ehejykb1.fsf@guru.guru-group.fi>\r
+       <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       <87oax6vt4u.fsf@ktab.red-bean.com>\r
+       <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       <87d2djr7o1.fsf@floss.red-bean.com>\r
+       <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+Date: Mon, 07 Jul 2014 12:35:54 -0500\r
+In-Reply-To:\r
+ <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       (Sebastian Lipp's message of "Sun, 06 Jul 2014 22:41:02 +0200")\r
+Message-ID: <8761j9kr5x.fsf@ktab.red-bean.com>\r
+User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+Reply-To: Karl Fogel <kfogel@red-bean.com>\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 07 Jul 2014 17:36:06 -0000\r
+\r
+Sebastian Lipp <bacuh@riseup.net> writes:\r
+>Karl Fogel <kfogel@red-bean.com>\r
+>> In general, supplying a log message with the patch with avoid such\r
+>> confusion.  If there is some prose expressing what the change is\r
+>> supposed to to, and giving any historical context (such as the mailing\r
+>> list thread starting from last year), then it will be easy for any\r
+>> reviewer to understand what the patch is intended to do, and check if it\r
+>> actually does that.\r
+>\r
+>Okay, next time I will provide that information inline. Thought keeping\r
+>References and In-Reply-To headers would be sufficient reference.\r
+\r
+Well, when the patch is committed into a version control system, it's\r
+going to need a log message (commit message) anyway.  Since that message\r
+is considered part of the change -- anyone reading the change will start\r
+by reading the commit message -- it's typical to just include it with\r
+the diff.\r
+\r
+The commit message can certainly include a reference to the email\r
+thread; in fact, it's good if it does so.\r
+\r
+Best,\r
+=C2=ADKarl\r