t9120: don't expect failure with SVN_HTTPD_PORT unset
authorStephen Boyd <bebarino@gmail.com>
Tue, 26 May 2009 06:15:47 +0000 (23:15 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 29 May 2009 07:53:43 +0000 (00:53 -0700)
The test still passes when SVN_HTTPD_PORT is not set. Futhermore, t9115
and t9118 don't check if SVN_HTTPD_PORT is set even though they both use
start_httpd() from lib-git-svn.sh. Admittedly, the test is not very
meaningful without SVN_HTTPD_PORT, as commit f5530b (support for funky
branch and project names over HTTP(S) 2007-11-11) states that the URI
escaping is only done over HTTP(S).

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9120-git-svn-clone-with-percent-escapes.sh

index 555a0189a7bd6412829da88a3e615208117eaa90..f159ab689bd5f7dfba1b27adb9dc68d8b65b67fe 100755 (executable)
@@ -14,17 +14,12 @@ test_expect_success 'setup svnrepo' '
        start_httpd
 '
 
-if test "$SVN_HTTPD_PORT" = ""
-then
-       test_expect_failure 'test clone with percent escapes - needs SVN_HTTPD_PORT set' 'false'
-else
-       test_expect_success 'test clone with percent escapes' '
-               git svn clone "$svnrepo/pr%20ject" clone &&
-               cd clone &&
-                       git rev-parse refs/${remotes_git_svn} &&
-               cd ..
-       '
-fi
+test_expect_success 'test clone with percent escapes' '
+       git svn clone "$svnrepo/pr%20ject" clone &&
+       cd clone &&
+               git rev-parse refs/${remotes_git_svn} &&
+       cd ..
+'
 
 stop_httpd