Re: [PATCH v2 1/5] Add a failing unit test for indexed mime types
authorJani Nikula <jani@nikula.org>
Thu, 15 Jan 2015 17:19:04 +0000 (19:19 +0200)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 21:47:23 +0000 (14:47 -0700)
3e/9f8e1016a9d1679fad4f4ae367a451b20cefb3 [new file with mode: 0644]

diff --git a/3e/9f8e1016a9d1679fad4f4ae367a451b20cefb3 b/3e/9f8e1016a9d1679fad4f4ae367a451b20cefb3
new file mode 100644 (file)
index 0000000..d183296
--- /dev/null
@@ -0,0 +1,153 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0D576431FDB\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:18:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.738\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.738 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EjnRN3RAqeQu for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Jan 2015 09:18:55 -0800 (PST)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 99C57431FD9\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:18:55 -0800 (PST)\r
+Received: by mail-we0-f181.google.com with SMTP id q58so15968587wes.12\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Jan 2015 09:18:53 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=w5nhOLEmClk67Lt3QUw1LOY8PGsneu7qNmtoGKuaYWM=;\r
+       b=GdIO86/4fzCTFZQelroPauqtAdkZWgYNQU3JuvfcsVk2e0d6xQ/bYK3yAQbZpiUbNl\r
+       DPoH8sXIyTtmionccMqZABmGKLsfsk1xjCFAZdlVs9Zd8bB3EPNs8h5mRJB3ISuB8Cv6\r
+       Es0H0bQT9NRpMw1QUnbHAAb7Sol2F4CKWc+Y6dVXJBqh0SMnJUwvN5UwHvIdRtnohvJc\r
+       I1ffiGiEkD2NU2gPc2NDwYWbvkr4MO3BJPna3b//MeABrUBBeM1P/lS+9aZxLHkxN6zu\r
+       Q9N3IhH/LbB43oI9AOPanTW1TaZIUKfMuWk+wcD2Jrgvd9Ewqd8io9ikT2oXpyccKhfH\r
+       h64A==\r
+X-Gm-Message-State:\r
+ ALoCoQl7q1MPK6Dej9RrZSFSHvLamM2mxVvVeHFsXMtmgfXuwkC0TH4VGNd5uim6HqQDfesyfhPE\r
+X-Received: by 10.181.29.198 with SMTP id jy6mr28475702wid.0.1421342333220;\r
+       Thu, 15 Jan 2015 09:18:53 -0800 (PST)\r
+Received: from localhost (mobile-internet-bcee14-89.dhcp.inet.fi.\r
+       [188.238.20.89])\r
+       by mx.google.com with ESMTPSA id h8sm8267860wiy.4.2015.01.15.09.18.52\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Thu, 15 Jan 2015 09:18:52 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Todd <todd@electricoding.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/5] Add a failing unit test for indexed mime types\r
+In-Reply-To: <87a91k9dj3.fsf@nikula.org>\r
+References: <1421193628-2699-1-git-send-email-todd@electricoding.com>\r
+       <1421193628-2699-2-git-send-email-todd@electricoding.com>\r
+       <87a91k9dj3.fsf@nikula.org>\r
+User-Agent: Notmuch/0.19+19~g9060a1f (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 15 Jan 2015 19:19:04 +0200\r
+Message-ID: <871tmw9d2v.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 15 Jan 2015 17:18:59 -0000\r
+\r
+On Thu, 15 Jan 2015, Jani Nikula <jani@nikula.org> wrote:\r
+> On Wed, 14 Jan 2015, Todd <todd@electricoding.com> wrote:\r
+>> ---\r
+>>  test/T190-multipart.sh | 32 ++++++++++++++++++++++++++++++++\r
+>>  1 file changed, 32 insertions(+)\r
+>>\r
+>> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh\r
+>> index 85cbf67..26f7c7a 100755\r
+>> --- a/test/T190-multipart.sh\r
+>> +++ b/test/T190-multipart.sh\r
+>> @@ -104,6 +104,30 @@ Content-Transfer-Encoding: base64\r
+>>  7w0K\r
+>>  --==-=-=--\r
+>>  EOF\r
+>> +\r
+>> +cat <<EOF > content_types\r
+>> +From: Todd <todd@example.com>\r
+>> +To: todd@example.com\r
+>> +Subject: odd content types\r
+>> +Date: Mon, 12 Jan 2014 18:12:32 +0000\r
+>> +User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu)\r
+>> +Message-ID: <KfjfO2WJBw2hrV2p0gjT@example.com>\r
+>> +MIME-Version: 1.0\r
+>> +Content-Type: multipart/alternative; boundary="==-=-=="\r
+>> +\r
+>> +--==-=-==\r
+>> +Content-Type: application/unique_identifier\r
+>> +\r
+>> +<p>This is an embedded message, with a multipart/alternative part.</p>\r
+>> +\r
+>> +--==-=-==\r
+>> +Content-Type: text/some_other_identifier\r
+>> +\r
+>> +This is an embedded message, with a multipart/alternative part.\r
+>> +\r
+>> +--==-=-==--\r
+>> +EOF\r
+>> +cat content_types >> ${MAIL_DIR}/odd_content_type\r
+>>  notmuch new > /dev/null\r
+>>  \r
+>>  test_begin_subtest "--format=text --part=0, full message"\r
+>> @@ -727,4 +751,12 @@ test_begin_subtest "html parts included"\r
+>>  notmuch show --format=json --include-html id:htmlmessage > OUTPUT\r
+>>  test_expect_equal_json "$(cat OUTPUT)" "$(cat EXPECTED.withhtml)"\r
+>>  \r
+>> +test_begin_subtest "indexes mime-type"\r
+>\r
+> test_subtest_known_broken\r
+>\r
+>> +output=$(notmuch search mimetype:application/unique_identifier | notmuch_search_sanitize)\r
+>> +test_expect_equal "$output" "thread:XXX   2014-01-12 [1/1] Todd; odd content types (inbox unread)"\r
+>> +\r
+>\r
+> test_begin_subtest "indexes mime-type #2"\r
+> test_subtest_known_broken\r
+>\r
+> Then you'd remove test_subtest_known_broken when you add the feature.\r
+>\r
+>> +output=$(notmuch search mimetype:text/some_other_identifier | notmuch_search_sanitize)\r
+>> +test_expect_equal "$output" "thread:XXX   2014-01-12 [1/1] Todd; odd content types (inbox unread)"\r
+>\r
+> I think I'd like to see a subtest for searching\r
+> mimetype:multipart/alternative (which should *not* find the message,\r
+> IIUC).\r
+\r
+Looking at the code in patch 3, I think it will index that. Please add\r
+the test so we know. ;)\r
+\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+>> +\r
+>> +\r
+>>  test_done\r
+>> -- \r
+>> 1.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r