[PATCH] test/notmuch-test: simple streamlining

diff --git a/64/24b5ce6533e72c9bca77ac77165cbcf1d01e64 b/64/24b5ce6533e72c9bca77ac77165cbcf1d01e64
new file mode 100644 (file)
index 0000000..cab2041
--- /dev/null
+++ b/64/24b5ce6533e72c9bca77ac77165cbcf1d01e64
@@ -0,0 +1,83 @@
+Return-Path: <too@guru-group.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 5232F6DE01BE\r
+ for <notmuch@notmuchmail.org>; Thu,  9 Jun 2016 12:21:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.242\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.242 tagged_above=-999 required=5 tests=[AWL=0.251, \r
+ HEADER_FROM_DIFFERENT_DOMAINS=0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id NCDgWdn_tVkt for <notmuch@notmuchmail.org>;\r
+ Thu,  9 Jun 2016 12:21:18 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id CFBC86DE01C2\r
+ for <notmuch@notmuchmail.org>; Thu,  9 Jun 2016 12:21:17 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+ id 9F3801001E5; Thu,  9 Jun 2016 22:20:57 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: notmuch@notmuchmail.org\r
+Cc: tomi.ollila@iki.fi\r
+Subject: [PATCH] test/notmuch-test: simple streamlining\r
+Date: Thu,  9 Jun 2016 22:20:56 +0300\r
+Message-Id: <1465500056-25510-1-git-send-email-tomi.ollila@iki.fi>\r
+X-Mailer: git-send-email 2.8.2\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 09 Jun 2016 19:21:26 -0000\r
+\r
+A few simple things that applies well to test/notmuch-test.sh\r
+\r
+- Shell does pathname expansion also without doing `echo ...` in subshell.\r
+\r
+- Redirections >/dev/null 2>/dev/null hide (improbable but) potential\r
+  serious errors; adding -f to rm instead.\r
+\r
+- Inter-file capitalization consistency in comments.\r
+\r
+- Unnecesary space removal.\r
+---\r
+ test/notmuch-test | 8 ++++----\r
+ 1 file changed, 4 insertions(+), 4 deletions(-)\r
+\r
+diff --git a/test/notmuch-test b/test/notmuch-test\r
+index 988dce6c59cb..e7d3151ce8cb 100755\r
+--- a/test/notmuch-test\r
++++ b/test/notmuch-test\r
+@@ -17,14 +17,14 @@ fi\r
+ \r
+ cd "$(dirname "$0")"\r
+ \r
+-TESTS=${NOTMUCH_TESTS:-`echo T[0-9][0-9][0-9]-*.sh`}\r
++TESTS=${NOTMUCH_TESTS:-T[0-9][0-9][0-9]-*.sh}\r
+ \r
+ # Clean up any results from a previous run\r
+-rm -r test-results >/dev/null 2>/dev/null\r
++rm -rf test-results\r
+ \r
+-# test for timeout utility\r
++# Test for timeout utility\r
+ if command -v timeout >/dev/null; then\r
+-    TEST_TIMEOUT_CMD="timeout 2m "\r
++    TEST_TIMEOUT_CMD="timeout 2m"\r
+     echo "INFO: using 2 minute timeout for tests"\r
+ else\r
+     TEST_TIMEOUT_CMD=""\r
+-- \r
+2.8.2\r
+\r