Re: [PATCH] emacs: Add a space after completed tag operations

diff --git a/c3/6ab273c51d091f655eebfbce6fac5645da27b2 b/c3/6ab273c51d091f655eebfbce6fac5645da27b2
new file mode 100644 (file)
index 0000000..f8e7cc6
--- /dev/null
+++ b/c3/6ab273c51d091f655eebfbce6fac5645da27b2
@@ -0,0 +1,110 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 19CD2431FC2\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 00:13:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id On3siqpaOiqB for <notmuch@notmuchmail.org>;\r
+       Fri, 25 Oct 2013 00:13:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 89E91431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 00:13:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 96108100217;\r
+       Fri, 25 Oct 2013 10:13:32 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Add a space after completed tag operations\r
+In-Reply-To: <1382650227-4055-1-git-send-email-amdragon@mit.edu>\r
+References: <1382650227-4055-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 25 Oct 2013 10:13:32 +0300\r
+Message-ID: <m2bo2desbn.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 Oct 2013 07:13:49 -0000\r
+\r
+On Fri, Oct 25 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Previously, when a user fully completed a tag operation, they had to\r
+> press space to begin entering another tag operation.  This is\r
+> different from, say, shell file name completion, which typically\r
+> inserts a space after an unambiguous completion under the assumption\r
+> that the user will want to enter more input.\r
+>\r
+> This patch tweaks `notmuch-read-tag-changes' to act more like shell\r
+> file name completion: after an unambiguous tag completion, it now\r
+> inserts a space, ready and waiting for another tagging operation from\r
+> the user.  This is backwards-compatible with old habits, since there's\r
+> no harm in putting an extra space.\r
+> ---\r
+\r
+LGTM. Tested by hand-editing "(mapcar ...)" part to the code (re-evaluated\r
+defun in *scratch* buffer) and it worked fine.\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Just because of the context, this must be applied on top of the\r
+> currently pending tag completion series\r
+> id:"1382487721-31776-1-git-send-email-amdragon@mit.edu".  The change\r
+> itself should be otherwise independent.\r
+>\r
+>  emacs/notmuch-tag.el | 12 ++++++++++--\r
+>  1 file changed, 10 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index 7b21006..8b921f1 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -229,8 +229,16 @@ initial input in the minibuffer."\r
+>          (set-keymap-parent map crm-local-completion-map)\r
+>          (define-key map " " 'self-insert-command)\r
+>          map)))\r
+> -    (delete "" (completing-read-multiple prompt\r
+> -            tag-list nil nil initial-input\r
+> +    (delete "" (completing-read-multiple\r
+> +            prompt\r
+> +            ;; Append the separator to each completion so when the\r
+> +            ;; user completes a tag they can immediately begin\r
+> +            ;; entering another.  `completing-read-multiple'\r
+> +            ;; ultimately splits the input on crm-separator, so we\r
+> +            ;; don't need to strip this back off (we just need to\r
+> +            ;; delete "empty" entries caused by trailing spaces).\r
+> +            (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list)\r
+> +            nil nil initial-input\r
+>              'notmuch-read-tag-changes-history))))\r
+>  \r
+>  (defun notmuch-update-tags (tags tag-changes)\r
+> -- \r
+> 1.8.4.rc3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r