Re: problems with nmbug and empty prefix (UnicodeWarning and broken pipe)

diff --git a/8f/99d1ab08a1fc0e5a80143f6b4151bdd61c39ae b/8f/99d1ab08a1fc0e5a80143f6b4151bdd61c39ae
new file mode 100644 (file)
index 0000000..e05719e
--- /dev/null
+++ b/8f/99d1ab08a1fc0e5a80143f6b4151bdd61c39ae
@@ -0,0 +1,108 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 5A7AE6DE0A9A\r
+ for <notmuch@notmuchmail.org>; Sun, 14 Feb 2016 04:22:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.307\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.307 tagged_above=-999 required=5 tests=[AWL=0.244,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ORlmMRsnt65U for <notmuch@notmuchmail.org>;\r
+ Sun, 14 Feb 2016 04:22:27 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 519606DE0943\r
+ for <notmuch@notmuchmail.org>; Sun, 14 Feb 2016 04:22:27 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aUvgO-0001GV-Ji; Sun, 14 Feb 2016 07:21:44 -0500\r
+Received: (nullmailer pid 5814 invoked by uid 1000);\r
+ Sun, 14 Feb 2016 12:22:24 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: problems with nmbug and empty prefix (UnicodeWarning and broken\r
+ pipe)\r
+In-Reply-To: <20160214063132.GD4265@odin.tremily.us>\r
+References: <87oabko293.fsf@zancas.localnet>\r
+ <20160213223357.GC4265@odin.tremily.us> <87ziv4813v.fsf@zancas.localnet>\r
+ <20160214063132.GD4265@odin.tremily.us>\r
+User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 14 Feb 2016 08:22:24 -0400\r
+Message-ID: <87twlbv5vj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Feb 2016 12:22:29 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+\r
+> On Sat, Feb 13, 2016 at 10:41:40PM -0400, David Bremner wrote:\r
+>> Traceback (most recent call last):\r
+>>   File "/home/bremner/.config/scripts/nmbug.real", line 834, in <module>\r
+>>     args.func(**kwargs)\r
+>>   File "/home/bremner/.config/scripts/nmbug.real", line 324, in commit\r
+>>     status =3D get_status()\r
+>>   File "/home/bremner/.config/scripts/nmbug.real", line 581, in get_stat=\r
+us\r
+>>     index =3D _index_tags()\r
+>>   File "/home/bremner/.config/scripts/nmbug.real", line 621, in _index_t=\r
+ags\r
+>>     git.stdin.write(line)\r
+\r
+>\r
+> This traceback is pointing at what should be a stream write, so I\r
+> don't see how urllib is involved there at all.  I guess this traceback\r
+> ends up in the =E2=80=9CBroken pipe=E2=80=9D message from your original p=\r
+ost?\r
+\r
+yes\r
+\r
+>\r
+>   for tag in tags:\r
+>       _LOG.debug('building a quoted path for {!r} / {!r}'.format(id, tag))\r
+>       path =3D 'tags/{id}/{tag}'.format(\r
+>           id=3D_hex_quote(string=3Did), tag=3D_hex_quote(string=3Dtag))\r
+>       yield '{mode} {hash}\t{path}\n'.format(mode=3Dmode, hash=3Dhash, pa=\r
+th=3Dpath)\r
+>\r
+\r
+I think the problem is not a bad tag, but a bad message-id. The last\r
+line of output before the UnicodeWarning and the broken pipe is\r
+\r
+building a quoted path for u'D1B4DEBCAFFC4A05A4D4349A6EC5C9D8@\xd1\xe5\xf0\=\r
+xe3\xe5\xe9-\xcf\xca' / u'unread'\r
+\r
+this corresponds to\r
+\r
+      id:D1B4DEBCAFFC4A05A4D4349A6EC5C9D8@=C3=91=C3=A5=C3=B0=C3=A3=C3=A5=C3=\r
+=A9-=C3=8F=C3=8A\r
+\r
+The original header looks like\r
+\r
+    Message-ID: <D1B4DEBCAFFC4A05A4D4349A6EC5C9D8@=C3=91=C3=A5=C3=B0=C3=A3=\r
+=C3=A5=C3=A9-=C3=8F=C3=8A>\r
+\r
+Visually I can't see what the encoding error might be, but I guess that\r
+doesn't matter; we should be able to handle message-ids as opaque byte\r
+strings.\r
+\r
+d\r