Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

diff --git a/1e/38f8fb3cb8f73655857f966cdf314052524b6e b/1e/38f8fb3cb8f73655857f966cdf314052524b6e
new file mode 100644 (file)
index 0000000..fca082f
--- /dev/null
+++ b/1e/38f8fb3cb8f73655857f966cdf314052524b6e
@@ -0,0 +1,92 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3482B431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 17:20:41 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QqjlILesnT9T for <notmuch@notmuchmail.org>;\r
+       Sat, 25 Jan 2014 17:20:35 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B6E15431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 17:20:35 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W7EOk-0005Lw-0J; Sat, 25 Jan 2014 21:20:30 -0400\r
+Received: (nullmailer pid 29273 invoked by uid 1000); Sun, 26 Jan 2014\r
+       01:20:26 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Mark Walters\r
+       <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el\r
+In-Reply-To: <m2a9ejkb05.fsf@guru.guru-group.fi>\r
+References: <87y5sipcjn.fsf@qmul.ac.uk>\r
+       <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bnyzoqq9.fsf@zancas.localnet> <m2a9ejkb05.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 25 Jan 2014 21:20:26 -0400\r
+Message-ID: <87y523mtd1.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 26 Jan 2014 01:20:41 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+>\r
+> How about doing it with defadvice with something like:\r
+>\r
+> (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice\r
+> this happening with emacs 23.3 -- David can check whether 23.4 if\r
+> affected)\r
+\r
+It's fixed in 23.4\r
+\r
+>\r
+> (if (and (= emacs-major-version 23) (< emacs-minor-version 4))\r
+>   (defadvice ido-completing-read (before notmuch-ido-mode-init activate)\r
+>       (unless (ido-mode) (ido-mode t))\r
+>       (ad-disable-advice 'ido-completing-read 'before 'notmuch-ido-mode-init)))\r
+\r
+Advice always seems over complex to me, but maybe I'm just\r
+prejudiced/ignorant.\r
+\r
+Can you decode/reverse-engineer the fix in \r
+\r
+    http://permalink.gmane.org/gmane.emacs.bugs/41957\r
+\r
+?\r
+\r
+Maybe the advice or whatever should call \r
+\r
+   (ido-init-completion-maps)\r
+   (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup)\r
+   (add-hook 'choose-completion-string-functions\r
+      'ido-choose-completion-string))\r
+\r
+Although that looks worryingly permanent.\r
+\r
+\r
+\r
+d\r