Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t

diff --git a/2c/f703e3d2d25780107df82a59603eb1cd739b72 b/2c/f703e3d2d25780107df82a59603eb1cd739b72
new file mode 100644 (file)
index 0000000..4ab8051
--- /dev/null
+++ b/2c/f703e3d2d25780107df82a59603eb1cd739b72
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 47BFC6DE00DD\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 06:03:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.312\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.312 tagged_above=-999 required=5 tests=[AWL=0.239,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id zKIOWxZ_NxPb for <notmuch@notmuchmail.org>;\r
+ Fri, 11 Dec 2015 06:03:07 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id ACF026DE005F\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 06:03:07 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1a7OHn-0000Z3-Gt; Fri, 11 Dec 2015 09:03:03 -0500\r
+Received: (nullmailer pid 15924 invoked by uid 1000);\r
+ Fri, 11 Dec 2015 14:03:05 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to\r
+ notmuch_database_t\r
+In-Reply-To: <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net>\r
+References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 11 Dec 2015 10:03:05 -0400\r
+Message-ID: <871tatf5gm.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 11 Dec 2015 14:03:13 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> This is in large part a duplicate of parts of crypto.c, but that code\r
+> is in the client (outside the library), and we don't want to entangle\r
+> the libgmime API with the libnotmuch API.\r
+>\r
+> I welcome better proposals for how to share this code explicitly\r
+> between the library and the client.\r
+\r
+Maybe I miss something obvious, but util/libutil.a is exactly there for\r
+sharing code between the library and the client.\r
+\r
+perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c\r
+\r
+I didn't look at the code yet, just the commentary.\r
+\r
+d\r