Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

diff --git a/a9/99ec3b7133b8cec20fbc1d593cdcf09456e523 b/a9/99ec3b7133b8cec20fbc1d593cdcf09456e523
new file mode 100644 (file)
index 0000000..4913c35
--- /dev/null
+++ b/a9/99ec3b7133b8cec20fbc1d593cdcf09456e523
@@ -0,0 +1,105 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CF3DE429E5B\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jan 2012 00:16:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KIH2xp4l7BKO for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Jan 2012 00:16:12 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 2213E429E54\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jan 2012 00:16:12 -0800 (PST)\r
+Received: by wibhi8 with SMTP id hi8so399089wib.26\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jan 2012 00:16:10 -0800 (PST)\r
+Received: by 10.180.14.72 with SMTP id n8mr11509298wic.22.1327306570800;\r
+       Mon, 23 Jan 2012 00:16:10 -0800 (PST)\r
+Received: from hotblack-desiato.hh.sledj.net\r
+       (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])\r
+       by mx.google.com with ESMTPS id l6sm157224wiv.11.2012.01.23.00.16.08\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 23 Jan 2012 00:16:09 -0800 (PST)\r
+Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)\r
+       id 682FBA0950; Mon, 23 Jan 2012 08:16:07 +0000 (GMT)\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH 2/3] emacs: Don't return the button from\r
+       `notmuch-show-insert-part-header'.\r
+In-Reply-To: <877h0jmn9a.fsf@servo.finestructure.net>\r
+References: <1327052612-1040-1-git-send-email-dme@dme.org>\r
+       <1327052612-1040-2-git-send-email-dme@dme.org>\r
+       <877h0jmn9a.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11+73~gd51b784 (http://notmuchmail.org) Emacs/24.0.92.1\r
+       (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 23 Jan 2012 08:16:03 +0000\r
+Message-ID: <cun8vky6dh8.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Gm-Message-State:\r
+ ALoCoQnrXz+hVSGJRwsilnrX1G544mYD3YLYHeOdhYXcfH9aQ7i9FhgYX4AwIlgucA3cA5yRM0o+\r
+Cc: notmuch <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Jan 2012 08:16:12 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+On Sun, 22 Jan 2012 13:38:09 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> This patch seems to include multiple distinct changes.  There is a\r
+> change to notmuch-show-insert-part-header, but a seemingly unrelated\r
+> change to the insertion of signed/encrypted part buttons.  They should\r
+> be in separate patches.\r
+\r
+I can separate them.\r
+\r
+> I'm also not sure I understand why the proposed changes to the\r
+> signed/encrypted button insertion functions are necessary or desired.\r
+> Was there a problem with the logic as it was?  What is gained by\r
+> having one function filled with special casing to handle two things,\r
+> rather than having two distinct functions?\r
+\r
+There was no problem with the logic. The code in the two functions was\r
+almost identical, so I'd like to make any future changes in just one\r
+place.\r
+\r
+You didn't actually answer my question - is the logic in the new\r
+function correct?\r
+\r
+> Finally, this patch throws out all the changes from the previous patch,\r
+> making the previous patch superfluous.\r
+\r
+I'll merge the first patch into the later (and presumably get accused of\r
+submitting patches which include multiple distinct changes :-)).\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk8dF0MACgkQaezQq/BJZRYZ/wCeIGyyNpORbO7KX09PJ54uwB2y\r
++IEAnitwy4y8BT0iMMvUhxlVEc/8q+kq\r
+=Diym\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r