--- /dev/null
+Return-Path: <schnouki@schnouki.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 7BB6D429E35\r
+ for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 05:23:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.1\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rxtQLnfCEmX2 for <notmuch@notmuchmail.org>;\r
+ Tue, 17 Jan 2012 05:23:11 -0800 (PST)\r
+Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])\r
+ by olra.theworths.org (Postfix) with ESMTP id 82361429E2F\r
+ for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 05:23:11 -0800 (PST)\r
+Received: from thor.loria.fr (thor.loria.fr [152.81.12.250])\r
+ by ks3536.kimsufi.com (Postfix) with ESMTPSA id AB2956A002A;\r
+ Tue, 17 Jan 2012 14:23:10 +0100 (CET)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;\r
+ s=key-schnouki; t=1326806590;\r
+ bh=RisWfQ3HLVin2az+UXLmHmfyUKI1Y/Nu/WP/wppA6qo=;\r
+ h=From:To:Subject:In-Reply-To:References:Date:Message-ID:\r
+ MIME-Version:Content-Type;\r
+ b=hEdQdEMpvXJXUjEtGqH4dpR+74Z6WAXCAjEUbbfZxBCpbnd5PLiYrZIDWPVZn1JmJ\r
+ NaaWXGEG2DGCn9YuQ2RuFPBXmaqIlu5XTPXO7IuxhKztHJwVRuJEUIpSoUJjuvHgBi\r
+ tf/jTQ+572/tl9J83ffcEF0LkeOUtmpD8ABQdvwA=\r
+From: Thomas Jost <schnouki@schnouki.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6\r
+In-Reply-To: <yf6lip65wbh.fsf@taco2.nixu.fi>\r
+References: <8739bea9lc.fsf@thor.loria.fr>\r
+ <1326797453-9405-1-git-send-email-schnouki@schnouki.net>\r
+ <1326797453-9405-2-git-send-email-schnouki@schnouki.net>\r
+ <yf6lip65wbh.fsf@taco2.nixu.fi>\r
+User-Agent: Notmuch/0.11+81~g9729eac (http://notmuchmail.org) Emacs/24.0.92.1\r
+ (x86_64-unknown-linux-gnu)\r
+Date: Tue, 17 Jan 2012 14:23:07 +0100\r
+Message-ID: <87y5t68nus.fsf@thor.loria.fr>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jan 2012 13:23:12 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 17 Jan 2012 14:48:34 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> w=\r
+rote:\r
+> > There are lots of API changes in gmime 2.6 crypto handling. By adding\r
+> > preprocessor directives, it is however possible to add gmime 2.6 compat=\r
+ibility\r
+> > while preserving compatibility with gmime 2.4 too.\r
+> >=20\r
+> > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".\r
+> >=20\r
+> > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31,=\r
+ the\r
+> > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto =\r
+test\r
+> > fails (signature verification with signer key unavailable) but this wil=\r
+l be hard\r
+> > to fix since the new API does not report the reason why a signature ver=\r
+ification\r
+> > fails (other than the human-readable error message).\r
+> > ---\r
+>=20\r
+> LGTM. Some whitespace things but most of those were there already;\r
+> I'd have one uncrustify round to be applied to the source and after\r
+> that be more strict about those...\r
+\r
+Thanks! I'll fix the whitespace issues in these patches when the source\r
+in Git is uncrustified then.\r
+\r
+> actually gmime 2.4 has GMIME_CHECK_VERSION defined as\r
+> g_mime_check_version (major, minor, micro) so the comment about it\r
+> is not entirely accurate (it is unusable in our context, though)\r
+\r
+Oops, yes. What I really meant is that GMIME_MAJOR_VERSION is not\r
+available as a preprocessor constant in 2.4, and GMIME_CHECK_VERSION is\r
+unusable in our context since it just calls a runtime function.\r
+\r
+By the way, how do you guys feel about setting GMIME_26 in\r
+notmuch-client.h? Is that good enough, or should it be done in configure\r
+so that gcc is called with "-DGMIME_26"?\r
+\r
+I filed a bug about gmime 2.6 incorrect handling of signatures with\r
+missing public keys: https://bugzilla.gnome.org/show_bug.cgi?id=3D668085.\r
+A patch is attached there, feel free to test and comment.\r
+\r
+(Arch Linux users: I made a little PKGBUILD that includes this patch if\r
+you want to build your own gmime 2.6.4:\r
+http://fichiers.schnouki.net/tmp/gmime-2.6.4-1.src.tar.gz)\r
+\r
+Best regards,\r
+\r
+=2D-=20\r
+Thomas/Schnouki\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQEcBAEBAgAGBQJPFXY7AAoJEMPdciX+bh5I2FUH/0eH0QTlJn9ytAXxKBtGu16N\r
+SUe9BpM5BbEKe/o7AaCyvECeTIrTo+6EGDYfuTOslamWS9T7M3mO2y75rcdzOMxL\r
+Ae5Du9rTfBGLPgl/RQyLVwyfUt3iaw9kMrVXG1Ed3mQ8bEtwk/nrt7RYH/dm4Yfn\r
+qw3N2KDAcemJN40c99U6KpGJN4G5huuf6UL+HfA+7lipGm4e2FP76BGHWMKWG2Ty\r
+1S8l4AWowpInfrudTx1k1u7SeNVgFjZ+9Md4FR2uiA7tJKAziwWqi5LUZ7On0fXa\r
+z7ZbpLoPrSCwxPyZtGIgazbLHMcNAMwTaNIoeHXnIwHwH/cl62uVRVFHLrVZ9hs=\r
+=E7Zy\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff