--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3D619431FBF\r
+ for <notmuch@notmuchmail.org>; Sun, 9 Feb 2014 02:17:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id q6CHW+JpeGBV for <notmuch@notmuchmail.org>;\r
+ Sun, 9 Feb 2014 02:17:28 -0800 (PST)\r
+Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 0CA1D431FBD\r
+ for <notmuch@notmuchmail.org>; Sun, 9 Feb 2014 02:17:28 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail1.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WCRRr-0002IS-U1; Sun, 09 Feb 2014 10:17:21 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WCRRr-0000CT-Jr; Sun, 09 Feb 2014 10:17:15 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for\r
+ part buttons\r
+In-Reply-To: <20140208173333.GC17142@odin.tremily.us>\r
+References: <877g9chbay.fsf@qmul.ac.uk>\r
+ <cover.1391423201.git.wking@tremily.us>\r
+ <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us>\r
+ <87vbwwosuw.fsf@qmul.ac.uk> <20140203203418.GO14197@odin.tremily.us>\r
+ <20140208173333.GC17142@odin.tremily.us>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 09 Feb 2014 10:17:14 +0000\r
+Message-ID: <8761ood1zp.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 93d7d7ccd5b3b0b9f479085e3c370da9 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 09 Feb 2014 10:17:34 -0000\r
+\r
+On Sat, 08 Feb 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+\r
+> On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:\r
+>> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:\r
+>> > My only other comment on the series is that you should update\r
+>> > devel/schemata in the first patch to reflect this addition.\r
+>>=20\r
+>> Ah, I didn't realize that file existed :p.\r
+>\r
+> Looking at this more, I'm unsure about whether or not I should bump\r
+> the version. b96ba63 (show: indicate length, encoding of omitted body\r
+> content, 2012-12-16) added part.content-length? and\r
+> part.content-transfer-encoding? and doesn't bump the version, while\r
+> abeac48 (search: Add stable queries to thread search results,\r
+> 2013-10-24) adds thread_summary.query and does bump the version. From\r
+> notmuch-client.h:\r
+>\r
+> Backwards-incompatible changes such as removing map fields, changing\r
+> the meaning of map fields, or changing the meanings of list elements\r
+> should increase this. New (required) map fields can be added without\r
+> increasing this.\r
+>\r
+> I think that the addition of part.content-description? should not bump\r
+> the version, but then I'm not sure how to document the change in\r
+> devel/schemata. I'm leaning towards something like:\r
+\r
+I think you just add the new field to the list of fields in the schemata\r
+in the appropriate place in the part section as\r
+\r
+content-description?: string,\r
+\r
+and you don't need to bump the version. I think this is because a client\r
+can safely ask for this field regardless of the notmuch version and\r
+won't get confused.=20\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+>\r
+> diff --git a/devel/schemata b/devel/schemata\r
+> index 41dc4a6..63d8aa4 100644\r
+> --- a/devel/schemata\r
+> +++ b/devel/schemata\r
+> @@ -26,6 +26,9 @@ v1\r
+> v2\r
+> - Added the thread_summary.query field.\r
+>\r
+> +Staged for v3\r
+> +- Added the part.content-descrition? field.\r
+> +\r
+> Common non-terminals\r
+> --------------------\r
+> =E2=80=A6\r
+>\r
+> Alternatively, there could be a minor version that gets bumped on each\r
+> tweak, however insignificant.\r
+>\r
+> Thoughts?\r
+>\r
+> Trevor\r
+>\r
+> --=20\r
+> This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
+> For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
projects / notmuch-archives.git / commitdiff