Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

diff --git a/a9/b60ebc77e647be1a75d890c866a478f9a5b3fc b/a9/b60ebc77e647be1a75d890c866a478f9a5b3fc
new file mode 100644 (file)
index 0000000..7a5e8ed
--- /dev/null
+++ b/a9/b60ebc77e647be1a75d890c866a478f9a5b3fc
@@ -0,0 +1,124 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C8B81431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:33:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sNsCmSPJGD4b for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Apr 2012 02:33:50 -0700 (PDT)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+       [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BAA4A431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:33:49 -0700 (PDT)\r
+Received: by lbdb5 with SMTP id b5so1776964lbd.26\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:33:48 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=MXEupgwvwdp0h8hrPQI3T77WxadoY5RIl1op0ccB7eg=;\r
+       b=qWYROo/t/qzlPALDjDJzZG3hPdpfl4oRtZnaecINB0ABwQWkezmsiGVKOOJSy1XYKh\r
+       Qv+S/nDaS4JxUToJK6krUSz7vNrVwQulgDET9aDRp8mGJjFagpuAFxuKxKzrqU2sAeNT\r
+       iF5lyahXuT8lCQ/vo1dHmgkhpsLEI18bv3Ss4n80k7mmwfgFP8jcZVSCJGllnyNSd5GU\r
+       qpFgSRN2Z1n+LjqckZVOqtbgqfcCOw++2VGWkuJWnFY7awdPR1xx9aJqo6ldorSHEovu\r
+       1ncM9fDiYbWNDXrlWd5r/Er9PRRTAKNHygJ50ARn58ziwn3NwpG6QOGXF78BXV4c9cTz\r
+       Whfw==\r
+Received: by 10.152.103.239 with SMTP id fz15mr13370977lab.42.1334655228113;\r
+       Tue, 17 Apr 2012 02:33:48 -0700 (PDT)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id ay4sm28181169lbb.2.2012.04.17.02.33.46\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 17 Apr 2012 02:33:47 -0700 (PDT)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to\r
+       notmuch-hello-refresh-hook\r
+In-Reply-To: <87hawivh73.fsf@nikula.org>\r
+References:\r
+ <bcfdc0d1969997e89e5abe0b320d77ee2109796a.1334651669.git.jani@nikula.org>\r
+       <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org>\r
+       <877gxeohh6.fsf@gmail.com> <87hawivh73.fsf@nikula.org>\r
+User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 17 Apr 2012 13:31:57 +0400\r
+Message-ID: <87y5pun1pu.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Apr 2012 09:33:53 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+>> Can you please give some explanaition why is this needed?  Would this\r
+>> change break custom hooks that do not expect any arguments?\r
+>\r
+> For patch 3/4. We don't want to display a message if someone calls\r
+> (notmuch-hello-update t) from some script, and notmuch-hello buffer\r
+> isn't even visible.\r
+>\r
+> Yes, it would break custom hooks. And a bunch of tests. But I think it\r
+> would be useful for custom hooks too, for the same reason as above.\r
+>\r
+\r
+Makes sense.  I think it should be mentioned in the commit message.\r
+Especially the fact that it breaks existing hooks.  We should mention it\r
+in the NEWS later as well.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> Jani.\r
+>\r
+>\r
+>\r
+>> \r
+>> Regards,\r
+>>   Dmitry\r
+>> \r
+>> Jani Nikula <jani@nikula.org> writes:\r
+>> \r
+>> > ---\r
+>> >  emacs/notmuch-hello.el |    2 +-\r
+>> >  1 files changed, 1 insertions(+), 1 deletions(-)\r
+>> >\r
+>> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+>> > index 9cd907a..0596bbe 100644\r
+>> > --- a/emacs/notmuch-hello.el\r
+>> > +++ b/emacs/notmuch-hello.el\r
+>> > @@ -776,7 +776,7 @@ following:\r
+>> >      (widget-setup)\r
+>> >  \r
+>> >      (goto-char final-target-pos))\r
+>> > -  (run-hooks 'notmuch-hello-refresh-hook)\r
+>> > +  (run-hook-with-args 'notmuch-hello-refresh-hook no-display)\r
+>> >    (setq notmuch-hello-first-run nil))\r
+>> >  \r
+>> >  (defun notmuch-folder ()\r
+>> > -- \r
+>> > 1.7.1\r
+>> >\r
+>> > _______________________________________________\r
+>> > notmuch mailing list\r
+>> > notmuch@notmuchmail.org\r
+>> > http://notmuchmail.org/mailman/listinfo/notmuch\r