Re: [PATCH] Return maximum of 150 results

diff --git a/01/aaffcc52cbdc8a2c15d1d76a9078dcc8c7fbc3 b/01/aaffcc52cbdc8a2c15d1d76a9078dcc8c7fbc3
new file mode 100644 (file)
index 0000000..40daae3
--- /dev/null
+++ b/01/aaffcc52cbdc8a2c15d1d76a9078dcc8c7fbc3
@@ -0,0 +1,88 @@
+Return-Path: <james.vasile@opensourcematters.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BED94429E25\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Aug 2011 08:38:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.363\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.363 tagged_above=-999 required=5\r
+       tests=[RDNS_DYNAMIC=0.363, TO_NO_BRKTS_DYNIP=1] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id BvH0IJjrokyE for <notmuch@notmuchmail.org>;\r
+       Fri, 19 Aug 2011 08:38:02 -0700 (PDT)\r
+Received: from hackervisions.org (67-207-143-141.slicehost.net\r
+       [67.207.143.141]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 36221431FD0\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Aug 2011 08:38:02 -0700 (PDT)\r
+Received: from ool-4572d87b.dyn.optonline.net ([69.114.216.123]\r
+ helo=localhost)       by hackervisions.org with esmtpsa\r
+ (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)  (Exim 4.72) (envelope-from\r
+ <james.vasile@opensourcematters.org>) id 1QuR9u-0007Zg-1j; Fri, 19 Aug 2011\r
+ 11:38:58 -0400\r
+From: James Vasile <james@hackervisions.org>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Return maximum of 150 results\r
+In-Reply-To: <87mxf5v43c.fsf@steelpick.2x.cz>\r
+References: <87zkj6um50.fsf@opensourcematters.org>\r
+       <87mxf5v43c.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.6.1-213-ge89ce87 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 19 Aug 2011 11:37:54 -0400\r
+Message-ID: <87r54hv2ct.fsf@opensourcematters.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Aug 2011 15:38:02 -0000\r
+\r
+On Fri, 19 Aug 2011 17:00:23 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> Hi James,\r
+> \r
+> On Fri, 19 Aug 2011, James Vasile wrote:\r
+> > Display a maximum of 150 results when searching for messages.  This\r
+> > prevents client lag when searches return thousands of results you'll\r
+> > never look at\r
+> \r
+> I would not like this feature. If I search for something I really want\r
+> to see everything. For example, if I want to remove inbox from many\r
+> messages, I would search for them and press "-inbox<ret>". With your\r
+> patch I'd not be sure whether there are some more messages or not.\r
+\r
+Ah, I do such things from the commandline, but you are right that there\r
+is a good use for such.\r
+\r
+> \r
+> > (use the Filter command to cut down results that exceed 150).\r
+> \r
+> You can start filtering while the previous search is still running, so I\r
+> do not see problem with having bug number of results.\r
+\r
+Yes, you can filter while the search runs, but that's not the only\r
+problem with huge search results.  On my system, I routinely do searches\r
+that return 15000+ messages when I'm only interested in the first\r
+several.  When I hit Q, Emacs annoyingly asks me for permission to kill\r
+the buffer because it has a running process.  And emacs lags as it\r
+processes all that data.\r
+\r
+> > \r
+> > Number of results can be changed by setting notmuch-max-results.\r
+> \r
+> If you really want this behavior, I propose to make the default value\r
+> of notmuch-max-results infinity.\r
+\r
+Yes, that's probably the right answer.  I'll rework the patch to do that.\r