Re: notmuch_thread_get_authors

diff --git a/9e/1b95c41babe653a92c809cd4f9868024300133 b/9e/1b95c41babe653a92c809cd4f9868024300133
new file mode 100644 (file)
index 0000000..36ab1a2
--- /dev/null
+++ b/9e/1b95c41babe653a92c809cd4f9868024300133
@@ -0,0 +1,128 @@
+Return-Path: <chevalier.ronny@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E09966DE1A2E\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 19:01:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.465\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.465 tagged_above=-999 required=5 tests=[AWL=0.355,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\r
+ SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Q_Qu5auWWvsP for <notmuch@notmuchmail.org>;\r
+ Tue, 21 Apr 2015 19:01:16 -0700 (PDT)\r
+Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com\r
+ [209.85.218.46])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 70EAA6DE17ED\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 19:01:16 -0700 (PDT)\r
+Received: by oiko83 with SMTP id o83so167960094oik.1\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 19:01:14 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+ :cc:content-type;\r
+ bh=CqH9Q3ydLFV5U3QKFjKd0MHE8+RjQayFSkm/WjbBJrk=;\r
+ b=C/kW+SGwvWOzp5G43c2Lm8EsWTMFKx0WA6yeigsN+Ph7xJFqedvwzTCLgXeUtX1Uuu\r
+ tY4MKHXD0FBsYuc/P0ymQNHxn1qrrpS5QNyvqQbCH+mNICFD/C2+mi3GGGm+4jtyZxbb\r
+ /jgtTHnZAmujWbrLicIFWJfu7xsknDDWa38p2QD0KSYsHK88vpiYudYV/rVVuhcd/DN3\r
+ h5D1Ch1NlUul60DviZU74d9DO3gR1MgUAbOevh6Jcchx1FOCK/IUSXgXKDeh+b6GUuW+\r
+ RHIkN8BYDYLonVo+eohELB75nUokvzR91CGBnm2GM0RXzF9U4lD+hDWbyG4YH1E5SPDA\r
+ Dciw==\r
+MIME-Version: 1.0\r
+X-Received: by 10.182.137.136 with SMTP id qi8mr20802764obb.51.1429668073833; \r
+ Tue, 21 Apr 2015 19:01:13 -0700 (PDT)\r
+Received: by 10.202.216.5 with HTTP; Tue, 21 Apr 2015 19:01:13 -0700 (PDT)\r
+In-Reply-To: <87lhhlhryd.fsf@csail.mit.edu>\r
+References:\r
+ <CABPZE7L5yX3tJH+1vMotxL7BHYoQd2BJSbzFuKTAxHgC5+6RHA@mail.gmail.com>\r
+ <87618qfk5l.fsf@maritornes.cs.unb.ca>\r
+ <CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com>\r
+ <87lhhlhryd.fsf@csail.mit.edu>\r
+Date: Wed, 22 Apr 2015 04:01:13 +0200\r
+Message-ID:\r
+ <CABPZE7JSE-WwTGBNpYZuZSepG=TrQSsMx-C0e2vU+7PT50HLbQ@mail.gmail.com>\r
+Subject: Re: notmuch_thread_get_authors\r
+From: Ronny Chevalier <chevalier.ronny@gmail.com>\r
+To: Austin Clements <aclements@csail.mit.edu>\r
+Content-Type: text/plain; charset=UTF-8\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 22 Apr 2015 02:01:20 -0000\r
+\r
+On Wed, Apr 22, 2015 at 3:28 AM, Austin Clements\r
+<aclements@csail.mit.edu> wrote:\r
+> On Tue, 21 Apr 2015, Ronny Chevalier <chevalier.ronny@gmail.com> wrote:\r
+>> On Tue, Apr 21, 2015 at 1:35 AM, David Bremner <david@tethera.net> wrote:\r
+>>> Ronny Chevalier <chevalier.ronny@gmail.com> writes:\r
+>> Austin Clements wrote:\r
+>>> And I think there's a fairly easy way to do it in C code that will\r
+>>> also prevent library interface bloat: instead of introducing new\r
+>>> library APIs to get at this information, just use the existing\r
+>>> notmuch_thread_get_messages API and construct the matched and\r
+>>> non-matched lists in the CLI.  Doing it in the CLI wouldn't require\r
+>>> the library to export yet another string list structure, which is\r
+>>> always a huge pain (thanks C!), and wouldn't introduce more "helper"\r
+>>> functions into the library API.\r
+>>\r
+>> I disagree with what Austin said. Because this does not solve the\r
+>> issue at all (or I misunderstood). The issue is with the notmuch API,\r
+>> if someone is using this library there no way it can parse properly\r
+>> the authors.\r
+>> In my case I am not using the CLI but the notmuch library, fixing this\r
+>> in the CLI is just an hack, and it does not fix the issue for the\r
+>> library users.\r
+>\r
+> My suggestion was in no way specific to the CLI. That was the context of\r
+> the discussion at the time, but for the purposes of this discussion, the\r
+> CLI is just another library user.\r
+\r
+Ok, sorry for misunderstanding.\r
+\r
+>\r
+> You're completely right that there's no way to reliably parse the\r
+> authors list returned by notmuch_thread_get_authors. So don't do\r
+> that. Just use notmuch_thread_get_messages, walk the messages list, and\r
+> build your own authors list. There's no need to introduce additional\r
+> complexity and surface area into the library API for this specific use\r
+> case (IMO, even notmuch_thread_get_authors shouldn't exist, but it's\r
+> there for legacy reasons.) Then you can get author lists for matched,\r
+> non-matched, matching a specific tag, just the to, just the from, counts\r
+> of how many times each author appeared, whatever you want.\r
+>\r
+\r
+Ok thanks!\r
+\r
+If I read the code correctly, _notmuch_thread_create in lib/thread.cc\r
+process every message to get information like tags, subject and\r
+authors. Since notmuch_thread_get_authors is here for legacy reasons,\r
+would it be better to generate the list of authors only when requested\r
+with notmuch_thread_get_authors (and cache the result of course)?\r
+Because, new code will not use this and will do this work manually,\r
+the generation of the list in intern consumes resources for nothing.\r
+\r
+>> Furthermore, I do not see why providing a string list NULL-terminated\r
+>> in C is a huge pain?\r
+>\r
+> See the notmuch_tags_* and notmuch_filesnames_* APIs. Those are just\r
+> string lists.\r
+>\r
+>> Otherwise, I agree with Mark Walters comments on the patch.\r
+>>\r
+>> If no one is working to fix this at the moment, I can send a patch?\r
+>>\r
+>> Ronny\r