Re: [PATCH v2 01/10] lib: add return status to database close and destroy

diff --git a/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444 b/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444
new file mode 100644 (file)
index 0000000..d4cb937
--- /dev/null
+++ b/31/168ac3edc9fb4911b62cba64e2cfa0b7bf3444
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4C259431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:41:38 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OC0R7HBQna0N for <notmuch@notmuchmail.org>;\r
+       Sat,  5 Jul 2014 05:41:30 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D177E431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:41:29 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1X3PG6-0005nN-SK; Sat, 05 Jul 2014 12:40:02 +0000\r
+Received: (nullmailer pid 23405 invoked by uid 1000); Sat, 05 Jul 2014\r
+       12:39:43 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 01/10] lib: add return status to database close and\r
+       destroy\r
+In-Reply-To: <1397653165-15620-2-git-send-email-novalazy@gmail.com>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+       <1397653165-15620-2-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 05 Jul 2014 09:39:43 -0300\r
+Message-ID: <871tu0rncg.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Jul 2014 12:41:38 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> From: Jani Nikula <jani@nikula.org>\r
+>\r
+> notmuch_database_close may fail in Xapian ->flush() or ->close(), so\r
+> report the status. Similarly for notmuch_database_destroy which calls\r
+> close.\r
+\r
+This patch looks OK, and it makes sense independent of what else\r
+follows with respect to notmuch-insert.\r
+\r
+With respect so SONAME bumping, we might be able to get away with out it\r
+here (although that could be un-portable or broken in a way I haven't\r
+seen yet), but we can also delay that decision until closer to the next\r
+release; I don't think it's as important to provide a stable ABI for\r
+people building from git, and I'd prefer to batch ABI changes into one\r
+SONAME bump.\r