2007-09-27 Marcus Brinkmann <marcus@g10code.de>

	* assuan-pipe-connect.c (pipe_connect_gpgme): Do not close process
	handle here.  Use this function also on Unix systems.

gpgme/
2007-09-27  Marcus Brinkmann  <marcus@g10code.de>

	* w32-glib-io.c (_gpgme_io_spawn),
	w32-qt-io.cpp (_gpgme_io_spawn), w32-io.c (_gpgme_io_spawn): Close
	the process handle, return 0.

tests/
2007-09-27  Marcus Brinkmann  <marcus@g10code.de>

	* t-engine-info.c (check_engine_info): Fix debug output.
	* gpg/Makefile.am (tests_unix): New variable.
	(TESTS): Use it.
	* gpg/t-support.h (passphrase_cb) [HAVE_W32_SYSTEM]: Use WriteFile instead of write.
	* gpg/t-wait.c [HAVE_W32_SYSTEM]: Define sleep as _sleep.

diff --git a/ChangeLog b/ChangeLog
index 553dda13493bf57a9a6c0f8b17db93171fc8ec13..5cb11bcddc436f428ed6f12df43fcc161acfd621 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2007-09-27  Marcus Brinkmann  <marcus@g10code.de>
 
+       * assuan-pipe-connect.c (pipe_connect_gpgme): Do not close process
+       handle here.  Use this function also on Unix systems.
+
        * assuan-pipe-connect.c (pipe_connect_gpgme): Fix last change.
 
        * assuan-pipe-connect.c (pipe_connect_gpgme): New function, use it

diff --git a/assuan/assuan-pipe-connect.c b/assuan/assuan-pipe-connect.c
index 359eb4947d5e5dee61de622fc8b6f40f1793d6c2..e38b7877df21aaf32a919c0d7b57ccf7356261f4 100644 (file)
--- a/assuan/assuan-pipe-connect.c
+++ b/assuan/assuan-pipe-connect.c
@@ -181,6 +181,8 @@ initial_handshake (assuan_context_t *ctx)
 }
 
 
+#ifndef _ASSUAN_IN_GPGME_BUILD_ASSUAN
+
 #ifndef HAVE_W32_SYSTEM
 #define pipe_connect pipe_connect_unix
 /* Unix version of the pipe connection code.  We use an extra macro to
@@ -365,6 +367,7 @@ pipe_connect_unix (assuan_context_t *ctx,
   return initial_handshake (ctx);
 }
 #endif /*!HAVE_W32_SYSTEM*/
+#endif /* _ASSUAN_IN_GPGME_BUILD_ASSUAN */
 
 
 #ifndef HAVE_W32_SYSTEM
@@ -550,6 +553,7 @@ socketpair_connect (assuan_context_t *ctx,
 
 
 
+
 #ifdef _ASSUAN_IN_GPGME_BUILD_ASSUAN
 
 #define pipe_connect pipe_connect_gpgme
@@ -570,7 +574,7 @@ pipe_connect_gpgme (assuan_context_t *ctx,
                    void *atforkvalue)
 {
   assuan_error_t err;
-  int pid;
+  int res;
   int rp[2];
   int wp[2];
   char mypidstr[50];
@@ -631,8 +635,8 @@ pipe_connect_gpgme (assuan_context_t *ctx,
   child_fds[2].fd = -1;
 
   /* Start the process.  */
-  pid = _gpgme_io_spawn (name, argv, child_fds, child_fds);
-  if (pid == -1)
+  res = _gpgme_io_spawn (name, argv, child_fds, child_fds);
+  if (res == -1)
     {
       _assuan_log_printf ("CreateProcess failed: %s\n", strerror (errno));
       _gpgme_io_close (rp[0]);
@@ -642,12 +646,8 @@ pipe_connect_gpgme (assuan_context_t *ctx,
       return _assuan_error (ASSUAN_General_Error);
     }
 
-  /* ERR contains the PID.  */
   (*ctx)->pid = 0;  /* We don't use the PID. */
 
-  /* FIXME: Should be done by GPGME.  */
-  CloseHandle ((HANDLE) pid); /* We don't need to wait for the process. */
-
   return initial_handshake (ctx);
 }
 

diff --git a/gpgme/ChangeLog b/gpgme/ChangeLog
index d8e1f96bce83c2c7163b508f8e3d39dc5668c361..87557d8a39ba2adbf5f318a7eee2fb017c4582c7 100644 (file)
--- a/gpgme/ChangeLog
+++ b/gpgme/ChangeLog
@@ -1,5 +1,9 @@
 2007-09-27  Marcus Brinkmann  <marcus@g10code.de>
 
+       * w32-glib-io.c (_gpgme_io_spawn),
+       w32-qt-io.cpp (_gpgme_io_spawn), w32-io.c (_gpgme_io_spawn): Close
+       the process handle, return 0.
+
        * gpgme.h (gpgme_protocol_t): Add GPGME_PROTOCOL_UNKNOWN.
        * gpgme.c (gpgme_get_protocol_name): Implement support for
        GPGME_PROTOCOL_UNKNOWN.

diff --git a/gpgme/gpgme.h b/gpgme/gpgme.h
index 57bb01162f3ebba984c68122119488f470543355..c0bc8e37931d9ad95cc9c90d97eda9e5b5cf699c 100644 (file)
--- a/gpgme/gpgme.h
+++ b/gpgme/gpgme.h
@@ -73,7 +73,7 @@ extern "C" {
    AM_PATH_GPGME macro) check that this header matches the installed
    library.  Warning: Do not edit the next line.  configure will do
    that for you!  */
-#define GPGME_VERSION "1.1.6-svn1258"
+#define GPGME_VERSION "1.1.6-svn1264"
 
 
 \f

diff --git a/gpgme/w32-glib-io.c b/gpgme/w32-glib-io.c
index 9d7eaf6cc4ff1566d03973022cec3e0c9be4a501..3bd162f5fcb6b034ac27817f8f45b22436a2a2e5 100644 (file)
--- a/gpgme/w32-glib-io.c
+++ b/gpgme/w32-glib-io.c
@@ -576,7 +576,11 @@ _gpgme_io_spawn (const char *path, char **argv,
                (int) GetLastError ());
 
   TRACE_SUC1 ("process=%p", pi.hProcess);
-  return 0;
+
+  /* We don't need to wait for the process. */
+  CloseHandle (pi.hProcess);
+
+  return TRACE_SYSRES (0);
 }
 
 

diff --git a/gpgme/w32-io.c b/gpgme/w32-io.c
index e83a2782425f07ccb69c1559a8f8210d145b83c1..4af1b68fa56adbaa7df0c0ee852508b5b1d87eae 100644 (file)
--- a/gpgme/w32-io.c
+++ b/gpgme/w32-io.c
@@ -1156,7 +1156,11 @@ _gpgme_io_spawn (const char *path, char **argv,
                (int) GetLastError ());
 
   TRACE_SUC1 ("process=%p", pi.hProcess);
-  return handle_to_pid (pi.hProcess);
+
+  /* We don't need to wait for the process. */
+  CloseHandle (pi.hProcess);
+
+  return TRACE_SYSRES (0);
 }
 
 

diff --git a/gpgme/w32-qt-io.cpp b/gpgme/w32-qt-io.cpp
index 50c4a97a22c576963baa5106d4530e9ff075f3df..20b537bd87c09c19dcaedc4de3c514e5b9700859 100644 (file)
--- a/gpgme/w32-qt-io.cpp
+++ b/gpgme/w32-qt-io.cpp
@@ -525,7 +525,11 @@ _gpgme_io_spawn (const char *path, char **argv,
                (int) GetLastError ());
 
   TRACE_SUC1 ("process=%p", pi.hProcess);
-  return 0;
+
+  /* We don't need to wait for the process. */
+  CloseHandle (pi.hProcess);
+
+  return TRACE_SYSRES (0);
 }
 
 

diff --git a/tests/ChangeLog b/tests/ChangeLog
index 9e115e49728bd00346ef860a0d7d604c5451b7c9..f57a44769408cf5be560d5cb1f0e8e5f32f09323 100644 (file)
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,11 @@
+2007-09-27  Marcus Brinkmann  <marcus@g10code.de>
+
+       * t-engine-info.c (check_engine_info): Fix debug output.
+       * gpg/Makefile.am (tests_unix): New variable.
+       (TESTS): Use it.
+       * gpg/t-support.h (passphrase_cb) [HAVE_W32_SYSTEM]: Use WriteFile instead of write.
+       * gpg/t-wait.c [HAVE_W32_SYSTEM]: Define sleep as _sleep.
+
 2007-09-14  Marcus Brinkmann  <marcus@g10code.de>
 
        * gpgsm/t-verify.c (main): Release TEXT and SIG.

diff --git a/tests/gpg/Makefile.am b/tests/gpg/Makefile.am
index 023d2aaafa0f137319b02b5e5c01f71bfe7a00fe..e5d9de9b7a0544d5b2704b70a5a03731ebbe5f6b 100644 (file)
--- a/tests/gpg/Makefile.am
+++ b/tests/gpg/Makefile.am
@@ -25,11 +25,17 @@ TESTS_ENVIRONMENT = GNUPGHOME=. GPG_AGENT_INFO=
 
 # The keylist tests must come after the import and the edit test.
 noinst_HEADERS = t-support.h
-TESTS = t-encrypt t-encrypt-sym t-encrypt-sign t-sign t-signers        \
-       t-decrypt t-verify t-decrypt-verify t-sig-notation \
-       t-export t-import t-trustlist t-eventloop t-edit \
-       t-keylist t-keylist-sig t-thread1 t-wait t-encrypt-large \
-       t-file-name
+
+if HAVE_W32_SYSTEM
+tests_unix =
+else
+tests_unix = t-eventloop t-thread1
+endif
+
+TESTS = t-encrypt t-encrypt-sym t-encrypt-sign t-sign t-signers                \
+       t-decrypt t-verify t-decrypt-verify t-sig-notation t-export     \
+       t-import t-trustlist t-edit t-keylist t-keylist-sig t-wait      \
+       t-encrypt-large t-file-name $(tests_unix)
 
 CLEANFILES = secring.gpg pubring.gpg trustdb.gpg
 DISTCLEANFILES = pubring.gpg~ random_seed gpg.conf

diff --git a/tests/gpg/t-support.h b/tests/gpg/t-support.h
index 0ed1ac84803bde7cb139bc9aed3205f3b7e5dad3..362b857a6265910e20eb43877912d3cf39a9d1e1 100644 (file)
--- a/tests/gpg/t-support.h
+++ b/tests/gpg/t-support.h
@@ -24,6 +24,10 @@
 #include <stdlib.h>
 #include <locale.h>
 
+#ifdef HAVE_W32_SYSTEM
+#include <windows.h>
+#endif
+
 #include <gpgme.h>
 
 #ifndef DIM
@@ -65,7 +69,13 @@ gpgme_error_t
 passphrase_cb (void *opaque, const char *uid_hint, const char *passphrase_info,
               int last_was_bad, int fd)
 {
+#ifdef HAVE_W32_SYSTEM
+  DWORD written;
+  WriteFile ((HANDLE) fd, "abc\n", 4, &written, 0);
+#else
   write (fd, "abc\n", 4);
+#endif
+
   return 0;
 }
 

diff --git a/tests/gpg/t-wait.c b/tests/gpg/t-wait.c
index c12835d7a99e584afbb4e67f898c59af3e4279a5..eec4d96d2d1950292ceee788fe1e75001565a4b8 100644 (file)
--- a/tests/gpg/t-wait.c
+++ b/tests/gpg/t-wait.c
@@ -1,6 +1,6 @@
 /* t-wait.c - Regression test.
    Copyright (C) 2000 Werner Koch (dd9jn)
-   Copyright (C) 2001, 2002, 2003, 2004, 2005 g10 Code GmbH
+   Copyright (C) 2001, 2002, 2003, 2004, 2005, 2007 g10 Code GmbH
 
    This file is part of GPGME.
  
@@ -29,6 +29,10 @@
 #include <stdio.h>
 #include <string.h>
 
+#ifdef HAVE_W32_SYSTEM
+#define sleep _sleep
+#endif
+
 #include <gpgme.h>
 
 #include "t-support.h"

diff --git a/tests/t-engine-info.c b/tests/t-engine-info.c
index 4af2d4a3ae89171597d633b80c2b047744970fdf..3864fe5f5e02fcf1f0fa171a5614833d249cf78f 100644 (file)
--- a/tests/t-engine-info.c
+++ b/tests/t-engine-info.c
@@ -1,5 +1,5 @@
 /* t-engine-info.c - Regression test for gpgme_get_engine_info.
-   Copyright (C) 2003, 2004 g10 Code GmbH
+   Copyright (C) 2003, 2004, 2007 g10 Code GmbH
 
    This file is part of GPGME.
  
@@ -54,13 +54,13 @@ check_engine_info (gpgme_engine_info_t info, gpgme_protocol_t protocol,
     }
   if (strcmp (info->file_name, file_name))
     {
-      fprintf (stderr, "Unexpected file name to executable %s (expected %s instead)",
+      fprintf (stderr, "Unexpected file name to executable %s (expected %s instead)\n",
               info->file_name, file_name);
       exit (1);
     }
   if (strcmp (info->req_version, req_version))
     {
-      fprintf (stderr, "Unexpected required version %s (expected %s instead)",
+      fprintf (stderr, "Unexpected required version %s (expected %s instead)\n",
               info->req_version, req_version);
       exit (1);
     }