--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2464F431FBD\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:33 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id GXMWcHb1G6TB for <notmuch@notmuchmail.org>;\r
+ Mon, 12 May 2014 15:08:25 -0700 (PDT)\r
+Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com\r
+ [74.125.82.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 7CA24431FAF for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:25 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f48.google.com with SMTP id b13so7568635wgh.19\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:24 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=bZYrAigDZfQsRqze+DxsCnf9aD7d/qIiCtJWz785+ZA=;\r
+ b=Kp2TO7gtEs+3BXDv2cx9hIiHUo/ZPUyT+hExw/qbskjIuSvgLqxLL4zyWhzv9d8K8n\r
+ fB9conbyMZCXUM6RJHKQ2aR0H/xcPsVi60YeIbOGI+f2atWVbDLKXhKiBQJGAd2EaEUN\r
+ uRDX1UCBM4GZlde9qyGPqhpynyq36KSWbZgYEJfjDWTzS388X4vY20aS6ruA2jeO5jXr\r
+ u6vLCDZdfLe6KQ5DuqOS25MAHnNNDMKVGGeiTnBjrlFa68QhH9s+51irTkoi8HSMbnTn\r
+ aQE09EN5Gx3f/UmJo5mW6d3ounlgbEJJPjdFKRTgPHqbW20S0GPVPfxVjW8jHW/Zw9AG\r
+ n60g==\r
+X-Received: by 10.194.92.177 with SMTP id cn17mr23616128wjb.18.1399932504076; \r
+ Mon, 12 May 2014 15:08:24 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+ by mx.google.com with ESMTPSA id\r
+ mw4sm18349818wib.12.2014.05.12.15.08.22 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Mon, 12 May 2014 15:08:23 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in\r
+ replies\r
+In-Reply-To: <1399897769-26809-1-git-send-email-dme@dme.org>\r
+References: <87sixdujkv.fsf@qmul.ac.uk>\r
+ <1399897769-26809-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 May 2014 23:08:20 +0100\r
+Message-ID: <87vbtak5uz.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 22:08:33 -0000\r
+\r
+\r
+On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> emacs: Improve the cited message included in replies\r
+>\r
+> I tried to do things in small increments to make it easier to review.\r
+>\r
+> v2:\r
+> - Don't run the text/plain hooks when generating the message to quote.\r
+>\r
+> v3:\r
+> - Remove the 'no-button code, as it's no longer used.\r
+> - Control the insertion of part headers using a function.\r
+> - Fix the tests.\r
+\r
+I think I broadly like this series. I haven't thought through all the\r
+ramifications yet so this is just some first thoughts. I will also send\r
+some comments on individual patches.\r
+\r
+In notmuch-show we go to notmuch-show-insert-part-*/* to\r
+notmuch-mm-display-part-inline and then leave the decision to inline to\r
+mm-inlined-types. I think this means that, by default, we will not\r
+inline signatures amongst other things.\r
+\r
+So at the least I think we should decide whether we want to override\r
+mm-inlined-types. Alternatively, and in my view preferably, we could\r
+have a function or variable of our own which says which parts to\r
+include. Indeed, if do it with a function we might be able to make an\r
+option to reply to mean "include parts currently shown in the\r
+notmuch-show buffer" which might be nice.\r
+\r
+There is a related question and possible bug that we might be able to\r
+do something about at the same time: should we include text parts in the\r
+reply if they have content-disposition attachment? I have been caught\r
+about by this on one occasion replying to a message with a 500K log file\r
+attached (and notmuch-show/wash becomes very slow with a 500K message!)\r
+\r
+Finally, I am not sure whether I like having buttons in the reply. My\r
+instinct is against, but they do add context.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+>\r
+>\r
+> David Edmondson (9):\r
+> emacs/show: Re-arrange determination if a part header is necessary\r
+> emacs/show: Allow the user to decide when part headers should be\r
+> inserted\r
+> emacs/show: Accommodate the lack of part header buttons\r
+> emacs/mua: Generate improved cited text for replies\r
+> emacs/show: Remove the 'no-buttons option of\r
+> `notmuch-show-insert-bodypart'\r
+> emacs/mua: Don't insert part headers in citations\r
+> test: Update the test output to accord with the reply changes\r
+> emacs/mua: Insert part headers depending on the message\r
+> test: Update the test output to accord with more reply changes\r
+>\r
+> emacs/notmuch-mua.el | 82 +++++++++++++++++++-----------\r
+> emacs/notmuch-show.el | 135 +++++++++++++++++++++++++++++++-------------------\r
+> test/T310-emacs.sh | 44 ++++++++++++++++\r
+> 3 files changed, 180 insertions(+), 81 deletions(-)\r
+>\r
+> -- \r
+> 2.0.0.rc0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff