Re: notmuch_thread_get_authors

diff --git a/74/56726e1cabb2ba117926d1f3bc59f09987afe7 b/74/56726e1cabb2ba117926d1f3bc59f09987afe7
new file mode 100644 (file)
index 0000000..2633a9a
--- /dev/null
+++ b/74/56726e1cabb2ba117926d1f3bc59f09987afe7
@@ -0,0 +1,108 @@
+Return-Path: <chevalier.ronny@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 8EA846DE13EA\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 05:22:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.239\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.239 tagged_above=-999 required=5 tests=[AWL=0.581,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\r
+ SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id LlrCLHrLb0ZU for <notmuch@notmuchmail.org>;\r
+ Tue, 21 Apr 2015 05:22:08 -0700 (PDT)\r
+Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com\r
+ [209.85.218.51])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 1AE3A6DE0AC2\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 05:22:08 -0700 (PDT)\r
+Received: by oica37 with SMTP id a37so148553987oic.0\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 05:22:07 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+ :cc:content-type;\r
+ bh=WKJ92D6kBa8x3vfZ+mz65JHb1i4VqGWyDEZzLk1ko+0=;\r
+ b=M+fRfai4U02kEM+6rjWcHnlv8ssee+4wxHEjhX8OHdQrTTskdHK99s9ZfXlRv7O4qh\r
+ Muw0qDbLY8HrU7+mL4tdpg3FzdFA8fxa06RI1dvcSVapj4mjH93mh3FcRPB4lc7WdVOV\r
+ 5tryJMsNQ7Ufkcv+mgRwLPBgeQYsPBNz9LVF1OchPXFuCILyvfe8uYg2RUOvpDXZFoCN\r
+ PHimeTN4G84NnHgS3hA+1MANEkYteLU9iJIR2adY6eAJLZwr4pkAcL+sOb7yJdTEszlV\r
+ 5pQkG6OPeKzPjhwAcUlcElfAd5po8PH4htE5HqRZDO7M41dwS1O41drchYINsQcp8Dqo\r
+ EXvg==\r
+MIME-Version: 1.0\r
+X-Received: by 10.202.64.195 with SMTP id n186mr17614843oia.53.1429618927246; \r
+ Tue, 21 Apr 2015 05:22:07 -0700 (PDT)\r
+Received: by 10.202.216.5 with HTTP; Tue, 21 Apr 2015 05:22:07 -0700 (PDT)\r
+In-Reply-To: <87618qfk5l.fsf@maritornes.cs.unb.ca>\r
+References:\r
+ <CABPZE7L5yX3tJH+1vMotxL7BHYoQd2BJSbzFuKTAxHgC5+6RHA@mail.gmail.com>\r
+ <87618qfk5l.fsf@maritornes.cs.unb.ca>\r
+Date: Tue, 21 Apr 2015 14:22:07 +0200\r
+Message-ID:\r
+ <CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com>\r
+Subject: Re: notmuch_thread_get_authors\r
+From: Ronny Chevalier <chevalier.ronny@gmail.com>\r
+To: David Bremner <david@tethera.net>\r
+Content-Type: text/plain; charset=UTF-8\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 Apr 2015 12:22:10 -0000\r
+\r
+On Tue, Apr 21, 2015 at 1:35 AM, David Bremner <david@tethera.net> wrote:\r
+> Ronny Chevalier <chevalier.ronny@gmail.com> writes:\r
+>\r
+>> Hi,\r
+>>\r
+>> I would like to know the reason behind the way we get authors from a\r
+>> thread, with notmuch_thread_get_authors.\r
+>>\r
+>\r
+> there is some related patches/discussion at\r
+>\r
+> http://thread.gmane.org/gmane.mail.notmuch.general/19422\r
+\r
+Ok thanks.\r
+\r
+Since I just subscribed to the mailing list, I can't reply to this the\r
+thread so I reply here.\r
+\r
+Austin Clements wrote:\r
+> And I think there's a fairly easy way to do it in C code that will\r
+> also prevent library interface bloat: instead of introducing new\r
+> library APIs to get at this information, just use the existing\r
+> notmuch_thread_get_messages API and construct the matched and\r
+> non-matched lists in the CLI.  Doing it in the CLI wouldn't require\r
+> the library to export yet another string list structure, which is\r
+> always a huge pain (thanks C!), and wouldn't introduce more "helper"\r
+> functions into the library API.\r
+\r
+I disagree with what Austin said. Because this does not solve the\r
+issue at all (or I misunderstood). The issue is with the notmuch API,\r
+if someone is using this library there no way it can parse properly\r
+the authors.\r
+In my case I am not using the CLI but the notmuch library, fixing this\r
+in the CLI is just an hack, and it does not fix the issue for the\r
+library users.\r
+\r
+Furthermore, I do not see why providing a string list NULL-terminated\r
+in C is a huge pain?\r
+\r
+Otherwise, I agree with Mark Walters comments on the patch.\r
+\r
+If no one is working to fix this at the moment, I can send a patch?\r
+\r
+Ronny\r