Re: [PATCH 1/3] database: Add notmuch_database_compact_close

diff --git a/03/f9489dc94ab096ea670100fcc4b11a479b4403 b/03/f9489dc94ab096ea670100fcc4b11a479b4403
new file mode 100644 (file)
index 0000000..b2b081b
--- /dev/null
+++ b/03/f9489dc94ab096ea670100fcc4b11a479b4403
@@ -0,0 +1,72 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A1959431FC2\r
+       for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 10:02:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 78swt2cGj9AT for <notmuch@notmuchmail.org>;\r
+       Sun, 20 Oct 2013 10:02:12 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BDE2E431FC0\r
+       for <notmuch@notmuchmail.org>; Sun, 20 Oct 2013 10:02:12 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id ECB5E10007D;\r
+       Sun, 20 Oct 2013 20:02:05 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] database: Add notmuch_database_compact_close\r
+In-Reply-To: <m2ob6xw4bw.fsf@guru.guru-group.fi>\r
+References: <1380745848-4972-1-git-send-email-bgamari.foss@gmail.com>\r
+       <1380745848-4972-2-git-send-email-bgamari.foss@gmail.com>\r
+       <m2ob6xw4bw.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16+112~g46b74be (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 20 Oct 2013 20:02:05 +0300\r
+Message-ID: <m2fvrv7u5u.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 20 Oct 2013 17:02:22 -0000\r
+\r
+On Thu, Oct 10 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+\r
+>\r
+> another, small change:\r
+>\r
+>       case "${xapian_version}" in\r
+> -         0.*|1.[01].*|1.2.[0-5])\r
+> +         0.*|1.[01].*|1.2.[0-5]|1.2.[0-5][^0-9]*)\r
+>               printf "No (only available with Xapian > 1.2.6).\n" ;;\r
+\r
+Forget the above suggestion, as mentioned below this would not work in\r
+dash. I presume attempting to compile compaction support will fail in \r
+case such support is not there. If we ever encounter such a bug report\r
+let's revisit this then...\r
+\r
+> someone might do version like 1.2.4-abc but probably not 1.2.04 (nor 1.2a.4)\r
+>\r
+> (side note: case $x in [^...]) works with bash (and ksh&zsh, but not with dash)\r
+\r
+Tomi\r