Re: [PATCH] Fix documentation for notmuch--tag-hook functions

diff --git a/8a/3fffddb1f9cbd62497119fdc52ac41ab06be08 b/8a/3fffddb1f9cbd62497119fdc52ac41ab06be08
new file mode 100644 (file)
index 0000000..79b9e62
--- /dev/null
+++ b/8a/3fffddb1f9cbd62497119fdc52ac41ab06be08
@@ -0,0 +1,94 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 93C876DE0243\r
+ for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 15:12:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.98\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.98 tagged_above=-999 required=5 tests=[AWL=0.328,\r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 7kcdMwOZ6I-k for <notmuch@notmuchmail.org>;\r
+ Tue, 16 Jun 2015 15:12:03 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id BDECC6DE01F5\r
+ for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 15:12:02 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id B610E100086;\r
+ Wed, 17 Jun 2015 01:11:38 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Fix documentation for notmuch--tag-hook functions\r
+In-Reply-To: <1434491240-31023-1-git-send-email-daniel@schoepe.org>\r
+References: <1434491240-31023-1-git-send-email-daniel@schoepe.org>\r
+User-Agent: Notmuch/0.20+12~gf3d9440 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 17 Jun 2015 01:11:38 +0300\r
+Message-ID: <m24mm7mhgl.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Jun 2015 22:12:05 -0000\r
+\r
+On Wed, Jun 17 2015, Daniel Schoepe <daniel@schoepe.org> wrote:\r
+\r
+> The second argument to notmuch-tag is now called tag-changes, but the\r
+> documentation for notmuch-before-tag-hook and notmuch-after-tag-hook\r
+> still used the old argument name `tags'. This resulted in broken hooks\r
+> when following the documentation.\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+> ---\r
+>  emacs/notmuch-tag.el | 4 ++--\r
+>  1 file changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index f54aa9d..c7f62c9 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -265,7 +265,7 @@ changed (the normal case) are shown using formats from\r
+>  (defcustom notmuch-before-tag-hook nil\r
+>    "Hooks that are run before tags of a message are modified.\r
+>  \r
+> -'tags' will contain the tags that are about to be added or removed as\r
+> +'tag-changes' will contain the tags that are about to be added or removed as\r
+>  a list of strings of the form \"+TAG\" or \"-TAG\".\r
+>  'query' will be a string containing the search query that determines\r
+>  the messages that are about to be tagged"\r
+> @@ -277,7 +277,7 @@ the messages that are about to be tagged"\r
+>  (defcustom notmuch-after-tag-hook nil\r
+>    "Hooks that are run after tags of a message are modified.\r
+>  \r
+> -'tags' will contain the tags that were added or removed as\r
+> +'tag-changes' will contain the tags that were added or removed as\r
+>  a list of strings of the form \"+TAG\" or \"-TAG\".\r
+>  'query' will be a string containing the search query that determines\r
+>  the messages that were tagged"\r
+> -- \r
+> 2.4.3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r