Re: [PATCH] emacs: Split the function notmuch-show-clean-address

diff --git a/a8/262f52aaa31ad4b07ec33cae38b654fc071157 b/a8/262f52aaa31ad4b07ec33cae38b654fc071157
new file mode 100644 (file)
index 0000000..ae96bda
--- /dev/null
+++ b/a8/262f52aaa31ad4b07ec33cae38b654fc071157
@@ -0,0 +1,163 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9D96A431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 31 Jul 2012 09:25:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id IETcrRbkjLoz for <notmuch@notmuchmail.org>;\r
+       Tue, 31 Jul 2012 09:25:58 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 322B7431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 31 Jul 2012 09:25:58 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SwFGZ-0005kp-V1; Tue, 31 Jul 2012 17:25:54 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SwFGZ-0002kp-Gy; Tue, 31 Jul 2012 17:25:51 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Split the function notmuch-show-clean-address\r
+In-Reply-To: <m2mx2gl6d1.fsf@guru.guru-group.fi>\r
+References: <87ehnw84e5.fsf@qmul.ac.uk> <m2mx2gl6d1.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.13.2+96~g634443c (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 31 Jul 2012 17:25:51 +0100\r
+Message-ID: <87boivzyls.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 960cb66c68eaa6edf5544b3d5f0877d3 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 31 Jul 2012 16:25:59 -0000\r
+\r
+On Tue, 31 Jul 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Sat, Jul 28 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>\r
+>> This function is also used by pick so split it out. Since, pick and show\r
+>> want a slightly different combination of name and email make the\r
+>> separated function return them as a pair, and let show or pick extract\r
+>> the combination they want from that.\r
+>> ---\r
+\r
+Many thanks for the review all these look clear improvements: I will\r
+post a new version as a reply to this email.\r
+\r
+> Put notmuch-clean-address before notmuch-show-clean-address so that\r
+> byte compilation don't complain about missing function.\r
+\r
+Fixed: I am curious though because I did not get any complaints from\r
+make. Are there some debug or similar things I should be setting?\r
+\r
+> (or move it to another file --- maybe later if it is sensible thing to do)\r
+\r
+I was vaguely thinking of moving it to lib after the split.\r
+\r
+> You could return the name-address pair as cons cell instead of list (?).\r
+\r
+This is a clear improvement.\r
+\r
+\r
+Thanks again\r
+\r
+Mark\r
+\r
+> (If you continue to use list you can replace (car (cdr ...)) with (cadr ...))\r
+>\r
+> Anyway, LGTM.\r
+>\r
+> Tomi\r
+>\r
+>>\r
+>> This change allows the removal of about 50 lines of duplicated code from\r
+>> notmuch-pick. Later, we may want to move the split out function to lib.\r
+>>\r
+>>  emacs/notmuch-show.el |   19 ++++++++++++++-----\r
+>>  1 files changed, 14 insertions(+), 5 deletions(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index 6335d45..0d8569d 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -354,6 +354,19 @@ operation on the contents of the current buffer."\r
+>>  (defun notmuch-show-clean-address (address)\r
+>>    "Try to clean a single email ADDRESS for display.  Return\r
+>>  unchanged ADDRESS if parsing fails."\r
+>> +  (let* ((clean-address (notmuch-clean-address address))\r
+>> +    (p-address (car clean-address))\r
+>> +    (p-name (car (cdr clean-address))))\r
+>> +    ;; If no name, return just the address.\r
+>> +    (if (not p-name)\r
+>> +   p-address\r
+>> +      ;; Otherwise format the name and address together.\r
+>> +      (concat p-name " <" p-address ">"))))\r
+>> +\r
+>> +(defun notmuch-clean-address (address)\r
+>> +  "Try to clean a single email ADDRESS for display.\r
+>> +Return (AUTHOR_EMAIL AUTHOR_NAME). Return (ADDRESS nil) if\r
+>> +parsing fails."\r
+>>    (condition-case nil\r
+>>      (let (p-name p-address)\r
+>>        ;; It would be convenient to use `mail-header-parse-address',\r
+>> @@ -401,11 +414,7 @@ unchanged ADDRESS if parsing fails."\r
+>>        (when (string= p-name p-address)\r
+>>     (setq p-name nil))\r
+>>  \r
+>> -      ;; If no name results, return just the address.\r
+>> -      (if (not p-name)\r
+>> -     p-address\r
+>> -   ;; Otherwise format the name and address together.\r
+>> -   (concat p-name " <" p-address ">")))\r
+>> +      (list p-address p-name))\r
+>>      (error address)))\r
+>>  \r
+>>  (defun notmuch-show-insert-headerline (headers date tags depth)\r
+>> -- \r
+>> 1.7.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r