--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0630A431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 13:47:39 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id JL0+zouBZvsQ for <notmuch@notmuchmail.org>;\r
+ Wed, 4 Jul 2012 13:47:38 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id DCEE4431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 13:47:37 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SmWTy-0000Ys-8C; Wed, 04 Jul 2012 21:47:32 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SmWTx-0002UW-S1; Wed, 04 Jul 2012 21:47:30 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result\r
+In-Reply-To: <1341354059-29396-2-git-send-email-amdragon@mit.edu>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+ <1341354059-29396-2-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+70~gb6a56e7 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 04 Jul 2012 21:47:25 +0100\r
+Message-ID: <87ipe3fe3m.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 6d6a5247bab7c72097b89a1063fcc164 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jul 2012 20:47:39 -0000\r
+\r
+On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> This simplifies the code and makes it no longer cubic in the number of\r
+> result fields.\r
+> ---\r
+> emacs/notmuch.el | 20 ++++++++++----------\r
+> 1 file changed, 10 insertions(+), 10 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index c6236db..be217a2 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -707,29 +707,29 @@ non-authors is found, assume that all of the authors match."\r
+> (overlay-put overlay 'isearch-open-invisible #'delete-overlay)))\r
+> (insert padding))))\r
+> \r
+> -(defun notmuch-search-insert-field (field date count authors subject tags)\r
+> +(defun notmuch-search-insert-field (field format date count authors subject tags)\r
+> (cond\r
+> ((string-equal field "date")\r
+> - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) date)\r
+> + (insert (propertize (format format date)\r
+> 'face 'notmuch-search-date)))\r
+> ((string-equal field "count")\r
+> - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) count)\r
+> + (insert (propertize (format format count)\r
+> 'face 'notmuch-search-count)))\r
+> ((string-equal field "subject")\r
+> - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) subject)\r
+> + (insert (propertize (format format subject)\r
+> 'face 'notmuch-search-subject)))\r
+> \r
+> ((string-equal field "authors")\r
+> - (notmuch-search-insert-authors (cdr (assoc field notmuch-search-result-format)) authors))\r
+> + (notmuch-search-insert-authors format authors))\r
+> \r
+> ((string-equal field "tags")\r
+> - (insert (concat "(" (propertize tags 'font-lock-face 'notmuch-tag-face) ")")))))\r
+> + (insert\r
+> + (format format (propertize tags 'font-lock-face 'notmuch-tag-face))))))\r
+\r
+Am I missing something or did the search result line previously ignore\r
+the user's specification for tags and automatically print it with inside\r
+()? Now this change does actually obey the user's specification.\r
+\r
+In principle that is a good thing, but the tag update code (when\r
+changing a tag on a message) seems to rely on the brackets to find\r
+something and errors out if the user format does not have any\r
+brackets. (The code has things like "(re-search-backward "(")" in it).\r
+\r
+Incidentally, patch 8 does change the format slightly by not padding the\r
+the date field string itself and only printing it padded. This (very\r
+mildly) breaks things if the user has customised\r
+notmuch-search-result-format\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+> \r
+> (defun notmuch-search-show-result (date count authors subject tags)\r
+> - (let ((fields) (field))\r
+> - (setq fields (mapcar 'car notmuch-search-result-format))\r
+> - (loop for field in fields\r
+> - do (notmuch-search-insert-field field date count authors subject tags)))\r
+> + (dolist (format notmuch-search-result-format)\r
+> + (notmuch-search-insert-field (car format) (cdr format)\r
+> + date count authors subject tags))\r
+> (insert "\n"))\r
+> \r
+> (defun notmuch-search-process-filter (proc string)\r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff