[PATCH] emacs: show: make return value of notmuch-show-get-prop explicit

diff --git a/b4/ae8437f91d6900769d318a3c34bf4d84c789e9 b/b4/ae8437f91d6900769d318a3c34bf4d84c789e9
new file mode 100644 (file)
index 0000000..b10df6b
--- /dev/null
+++ b/b4/ae8437f91d6900769d318a3c34bf4d84c789e9
@@ -0,0 +1,94 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 20374431FC0\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 11:03:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2rN0NTq0sHPW for <notmuch@notmuchmail.org>;\r
+       Wed, 16 Jul 2014 11:03:46 -0700 (PDT)\r
+Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com\r
+       [209.85.212.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 97A5C431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 11:03:46 -0700 (PDT)\r
+Received: by mail-wi0-f175.google.com with SMTP id ho1so6684237wib.8\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 11:03:44 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:in-reply-to:references;\r
+       bh=r/AqnI9AnsZCsKKKR/FaSvL2OF1gWgF71uFggfCw6Wc=;\r
+       b=HNnn9U4xsU/cSxMpNx97bH1l9EGPt+1g/YPc1nEGNavXBkOshGI9kqXVdCWCD7lKMR\r
+       hWYhfrue28iQ1nLDzX4rRygAm5e3hn3Gf/Jh5nClhkt0+Bumd2oWl0ceh8vFMOOBBVO3\r
+       KGn0fYFFYTNuGU/wAFqVs9uxzEpmF0PtJy+oOqhonoPmHZSgwYHe8cHxIKZEf31P84NE\r
+       iFysXuVBXRa157+QJEfhA5pFBsJuE+FMRxbme/fqSue9tyN98DdOXizwiIopUQuPFK72\r
+       M/uBvyQNgKk2eNk/AVI9HuLIdoz3BiA0Dz+N0Mn0qmZsUG8JVHUuilSgvVWtwRmnJLAN\r
+       TOng==\r
+X-Received: by 10.180.78.100 with SMTP id a4mr1188087wix.36.1405533824039;\r
+       Wed, 16 Jul 2014 11:03:44 -0700 (PDT)\r
+Received: from localhost ([194.42.225.52])\r
+       by mx.google.com with ESMTPSA id u10sm68408wjz.43.2014.07.16.11.03.43\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Wed, 16 Jul 2014 11:03:43 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: show: make return value of notmuch-show-get-prop\r
+       explicit\r
+Date: Wed, 16 Jul 2014 19:03:16 +0100\r
+Message-Id: <1405533796-8780-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.10.4\r
+In-Reply-To: <874myhabi0.fsf@maritornes.cs.unb.ca>\r
+References: <874myhabi0.fsf@maritornes.cs.unb.ca>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 16 Jul 2014 18:03:54 -0000\r
+\r
+This makes the fact the notmuch-show-get-prop returns nil if the major\r
+mode is neither show not tree explicit.\r
+---\r
+This is a followup to the patch and review comment at \r
+id:874myhabi0.fsf@maritornes.cs.unb.ca\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+ emacs/notmuch-show.el |    3 ++-\r
+ 1 file changed, 2 insertions(+), 1 deletion(-)\r
+\r
+diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+index 529baa9..7549fbb 100644\r
+--- a/emacs/notmuch-show.el\r
++++ b/emacs/notmuch-show.el\r
+@@ -1485,7 +1485,8 @@ they just need the correct message properties."\r
+                  (cond ((eq major-mode 'notmuch-show-mode)\r
+                         (notmuch-show-get-message-properties))\r
+                        ((eq major-mode 'notmuch-tree-mode)\r
+-                        (notmuch-tree-get-message-properties))))))\r
++                        (notmuch-tree-get-message-properties))\r
++                       (t nil)))))\r
+     (plist-get props prop)))\r
+ \r
+ (defun notmuch-show-get-message-id (&optional bare)\r
+-- \r
+1.7.10.4\r
+\r