--- /dev/null
+Return-Path: <cceleri@cs.stanford.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 194A9431FC0\r
+ for <notmuch@notmuchmail.org>; Sat, 10 May 2014 07:56:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id DCLQboCPX427 for <notmuch@notmuchmail.org>;\r
+ Sat, 10 May 2014 07:55:59 -0700 (PDT)\r
+Received: from smtp3.cs.Stanford.EDU (smtp3.cs.Stanford.EDU [171.64.64.27])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 3ABD1431FBF\r
+ for <notmuch@notmuchmail.org>; Sat, 10 May 2014 07:55:59 -0700 (PDT)\r
+Received: from lumumba.torservers.net ([77.247.181.163] helo=jane.lan)\r
+ by smtp3.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)\r
+ (Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)\r
+ id 1Wj8gr-0003aP-TY; Sat, 10 May 2014 07:55:56 -0700\r
+From: Charles Celerier <cceleri@cs.stanford.edu>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.\r
+In-Reply-To: <87lhua3qvv.fsf@maritornes.cs.unb.ca>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+ <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu>\r
+ <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>\r
+ <87d2fov2qj.fsf@maritornes.cs.unb.ca> <m2zjisnwie.fsf@jane.lan>\r
+ <87a9arvs9b.fsf@maritornes.cs.unb.ca> <m2iopfoihw.fsf@jane.lan>\r
+ <87lhua3qvv.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-apple-darwin13.1.0)\r
+Date: Sat, 10 May 2014 10:55:43 -0400\r
+Message-ID: <m24n0xy974.fsf@jane.lan>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Scan-Signature: 1423d2bdf1536ba32d3e1b7a7c800682\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 May 2014 14:56:07 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+>\r
+>> At this point, I'm not sure how to create a better version of this\r
+>> patch. Are we renaming functions in notmuch-private.h? Should we stick\r
+>> with objdump or switch to using nm?\r
+>\r
+> I'd go with renaming any functions that start with notmuch to start with\r
+> _notmuch.\r
+\r
+Ok. Should I pull the patch from\r
+id:1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu into this\r
+patch series?\r
+\r
+> Since it seems neither nm nor objdump provides uniform output between\r
+> OS/X and Linux, there isn't an obvious advantage to switching to nm. Any\r
+> idea if objdump can be made to work (in this test) on OS/X ?\r
+\r
+I can install GNU objdump on OS/X, but the problem seems to be that\r
+objdump changes its output depending on the object file format (see -t\r
+option documentation in objdump(1)). What does the output of nm look\r
+like for you? Is really that different? Here is what my objdump output\r
+looks like:\r
+\r
+ $ objdump -t lib/*.o | sed -n '/\[\.text\] __\?notmuch/p' | tail\r
+ 00000000000009a0 g 0f SECT 01 0000 [.text] _notmuch_thread_get_authors\r
+ 0000000000000990 g 0f SECT 01 0000 [.text] _notmuch_thread_get_matched_messages\r
+ 0000000000000960 g 0f SECT 01 0000 [.text] _notmuch_thread_get_messages\r
+ 00000000000009d0 g 0f SECT 01 0000 [.text] _notmuch_thread_get_newest_date\r
+ 00000000000009c0 g 0f SECT 01 0000 [.text] _notmuch_thread_get_oldest_date\r
+ 00000000000009b0 g 0f SECT 01 0000 [.text] _notmuch_thread_get_subject\r
+ 00000000000009e0 g 0f SECT 01 0000 [.text] _notmuch_thread_get_tags\r
+ 0000000000000970 g 0f SECT 01 0000 [.text] _notmuch_thread_get_thread_id\r
+ 0000000000000950 g 0f SECT 01 0000 [.text] _notmuch_thread_get_toplevel_messages\r
+ 0000000000000980 g 0f SECT 01 0000 [.text] _notmuch_thread_get_total_messages\r
+\r
+I suppose we could just account for the difference in output of objdump\r
+on OS/X, but I was hoping that the output of nm would be more consistent\r
+since its a simpler program.\r
+\r
+chuck\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG/MacGPG2 v2.0.22 (Darwin)\r
+\r
+iQEcBAEBAgAGBQJTbj3wAAoJEOjk698fDjuAYEMH/iNwqlM0QtSt85w0uuFvcVpz\r
+MwU86+EcpnSMk5Qw1ygzn8NKZHNbsR32Lka1Nko3PCzr+Uk0I35MIZkBoN08q6QX\r
+snN0ME0/4VdtlEAaSoHbtK2KgPSGS8wBlcUQmVNoC5FV3qarUnzNK0qORdZ1QftG\r
+GBuoNAY68l9UHp5RbQ+9cpxI2C8CESDc6IBXmYZemZOGlYKrqQiDk7PJOq+fUwPG\r
+661ZV0HTGQ5BHZnSsXDYk3jIjeQTxfqJqWziTqwLAikx3Z7O7L/2laObP+ZrlQ4U\r
+RjdkVdrfZWVk7ofeNwmqYC0eAs7O1V1TU2ijHTWHWFOw09b+DEo2nvZ5dshhpZE=\r
+=Hio3\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff