Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

diff --git a/bd/9666ea92573a43bfe39d5e7d96b200b2597619 b/bd/9666ea92573a43bfe39d5e7d96b200b2597619
new file mode 100644 (file)
index 0000000..f791c78
--- /dev/null
+++ b/bd/9666ea92573a43bfe39d5e7d96b200b2597619
@@ -0,0 +1,113 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EAB68429E3B\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 01:05:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id LVECzqAwR6CZ for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Jan 2012 01:05:29 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4FC47429E2F\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 01:05:29 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Rn4yr-0006zD-3l; Tue, 17 Jan 2012 09:05:25 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Rn4yq-0003Vg-SG; Tue, 17 Jan 2012 09:05:24 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as\r
+       saving\r
+In-Reply-To: <20120117022330.GE16740@mit.edu>\r
+References: <1326629796-11436-1-git-send-email-markwalters1009@gmail.com>\r
+       <1326629796-11436-2-git-send-email-markwalters1009@gmail.com>\r
+       <87wr8r5trv.fsf@servo.finestructure.net>\r
+       <87lip7fhkc.fsf@qmul.ac.uk> <20120117022330.GE16740@mit.edu>\r
+User-Agent: Notmuch/0.11~rc2+73~g1ea2b60 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 17 Jan 2012 09:06:11 +0000\r
+Message-ID: <8739beitq4.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: c28cfe8cf3b196100d0309f2d0490ee4 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.7\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.7 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.6 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jan 2012 09:05:30 -0000\r
+\r
+\r
+> > I wonder if the "problem" comes from me doing things in a non-lispy\r
+> > fashion (I am completely new to lisp). Thus\r
+> > notmuch-show-part-button-default-action is a variable that gets passed\r
+> > around rather than a function.\r
+> \r
+> Sorry, I should have looked at the bigger context in this patch.  I\r
+> think Jameson was implying that notmuch-show-part-button-default\r
+> should change to\r
+> \r
+> (defun notmuch-show-part-button-default (&optional button)\r
+>   (interactive)\r
+>   (funcall notmuch-show-part-button-default-action button))\r
+> \r
+> I would go one step further and say that each action should probably\r
+> be a separate function.  That is, break notmuch-show-part-action into\r
+> separate functions and simply invoke the appropriate function, rather\r
+> than performing a fixed data dispatch.  This would be more flexible\r
+> and Lispy.  It may be that your approach works out better, but I'd at\r
+> least give this a shot.\r
+\r
+I am happy to make that change. My original patch in the summer was more\r
+like that:\r
+id:"CALUdzSWAto+4mCUOOMk+8vFs+Pog-xUma6u-Aqx2M6-sbyQROg@mail.gmail.com"\r
+\r
+Is that more what you had in mind? (Only in broad terms: Obviously I\r
+would need to add in the customization and default function etc). I\r
+decided that I didn't like the code duplication (but I am completely new\r
+to lisp) which is why I changed it for this submission.\r
+\r
+Best wishes\r
+\r
+Mark\r