Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

diff --git a/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd b/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd
new file mode 100644 (file)
index 0000000..737f0e7
--- /dev/null
+++ b/2e/8fc0f6b19a7da36c9b9a10e7528ad8dc22aacd
@@ -0,0 +1,75 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EE8B4431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:30:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id C8gXqMJ-ltjL for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 16:29:57 -0700 (PDT)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5BC1B431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 16:29:57 -0700 (PDT)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1XavFU-0000VZ-Vw; Sun, 05 Oct 2014 19:29:57 -0400\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1XavFU-0004fU-N1; Sun, 05 Oct 2014 19:29:56 -0400\r
+Date: Sun, 5 Oct 2014 19:29:56 -0400\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature\r
+Message-ID: <20141005232956.GD7970@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>\r
+       <87d2a6q4hf.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87d2a6q4hf.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Oct 2014 23:30:03 -0000\r
+\r
+Quoth David Bremner on Oct 05 at 10:56 am:\r
+> Austin Clements <aclements@csail.mit.edu> writes:\r
+> > +    if (new_features & NOTMUCH_FEATURE_GHOSTS) {\r
+> > +  t_end = db->metadata_keys_end ("thread_id_");\r
+> > +  for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)\r
+> > +      ++total;\r
+> > +    }\r
+> \r
+> It would be nice to have the comment below, or something like it, for\r
+> the loop above.\r
+\r
+  /* The ghost message upgrade converts all thread_id_*\r
+   * metadata values into ghost message documents. */\r
+sound good?\r
+\r
+> > +    /* Perform metadata upgrades. */\r
+> > +\r
+> > +    /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing\r
+> > +     * messages were stored as database metadata. Change these to\r
+> > +     * ghost messages.\r
+> > +     */\r