[PATCH v3 13/20] insert: fsync after writing tmp file

diff --git a/d8/470a3e8605d658470bcb798a484de5787715e2 b/d8/470a3e8605d658470bcb798a484de5787715e2
new file mode 100644 (file)
index 0000000..40118a8
--- /dev/null
+++ b/d8/470a3e8605d658470bcb798a484de5787715e2
@@ -0,0 +1,85 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7B2B7431FDB\r
+       for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:48 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DOnICxx3CAeQ for <notmuch@notmuchmail.org>;\r
+       Sat, 19 Jan 2013 16:51:48 -0800 (PST)\r
+Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com\r
+       [209.85.160.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 84924429E41\r
+       for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:37 -0800 (PST)\r
+Received: by mail-pb0-f50.google.com with SMTP id wz7so2689974pbc.9\r
+       for <notmuch@notmuchmail.org>; Sat, 19 Jan 2013 16:51:36 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to\r
+       :references; bh=8ya8FZd2NothubvelH0oCk8DDpSG2jg9ICl+hjH0GsE=;\r
+       b=0/4th3sjYnJyqhDlYdPvnPhygeHaS/tylo0C+wpVYXv/KFty8EcJ0pK9PcAV20ZUq9\r
+       NhcpbIGbBQkwtKoUh8UFZswl514SB5Twcvqzm2NU6U8CK1NDHtTz4Yz3XbRZKDzqIO5H\r
+       IbK0A6+l8oKZiS9qNW1aRoyEnD/NsKtiIXIcLbwwnno0YQe6AOnFUVyxHosZwmTvAlvA\r
+       J8wewQ5xhqR2eLlON471D4KRiB4LxzhyJaTSTXRNee+X8DR4OoXCw5BDvkoelii98tFs\r
+       0ayPkRmXqysktcefC6TfgD4se/KLORe/AKRIWk7X8Ltnnygqq135pXgXz/8Hk4TpAxpp\r
+       OiwA==\r
+X-Received: by 10.69.1.73 with SMTP id be9mr18849166pbd.116.1358643096695;\r
+       Sat, 19 Jan 2013 16:51:36 -0800 (PST)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id i5sm6271689pax.13.2013.01.19.16.51.34\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 19 Jan 2013 16:51:36 -0800 (PST)\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 13/20] insert: fsync after writing tmp file\r
+Date: Sun, 20 Jan 2013 11:49:57 +1100\r
+Message-Id: <1358643004-14522-14-git-send-email-novalazy@gmail.com>\r
+X-Mailer: git-send-email 1.7.12.1\r
+In-Reply-To: <1358643004-14522-1-git-send-email-novalazy@gmail.com>\r
+References: <1358643004-14522-1-git-send-email-novalazy@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 20 Jan 2013 00:51:50 -0000\r
+\r
+Flush the tmp file to disk after writing for durability.\r
+---\r
+ notmuch-insert.c | 4 ++++\r
+ 1 file changed, 4 insertions(+)\r
+\r
+diff --git a/notmuch-insert.c b/notmuch-insert.c\r
+index 85acaea..60855c1 100644\r
+--- a/notmuch-insert.c\r
++++ b/notmuch-insert.c\r
+@@ -305,6 +305,10 @@ insert_message (void *ctx, notmuch_database_t *notmuch, int fdin,\r
+       return FALSE;\r
+     }\r
+     ret = copy_stdin (fdin, fdout);\r
++    if (ret && fsync (fdout) != 0) {\r
++      fprintf (stderr, "Error: fsync failed: %s\n", strerror (errno));\r
++      ret = FALSE;\r
++    }\r
+     close (fdout);\r
+     if (ret) {\r
+       ret = maildir_move_tmp_to_new (tmppath, newpath);\r
+-- \r
+1.7.12.1\r
+\r