Re: [PATCH] perf: Clean corpus and caches in distclean, not clean
authorTomi Ollila <tomi.ollila@iki.fi>
Tue, 22 Oct 2013 06:03:46 +0000 (09:03 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:57:31 +0000 (09:57 -0800)
59/e6288f969427e54293f1eabf78da9b9b967832 [new file with mode: 0644]

diff --git a/59/e6288f969427e54293f1eabf78da9b9b967832 b/59/e6288f969427e54293f1eabf78da9b9b967832
new file mode 100644 (file)
index 0000000..46732fe
--- /dev/null
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4FB8D431FC7\r
+       for <notmuch@notmuchmail.org>; Mon, 21 Oct 2013 23:03:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y9CDBSj2REk5 for <notmuch@notmuchmail.org>;\r
+       Mon, 21 Oct 2013 23:03:53 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 46E83431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 21 Oct 2013 23:03:53 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 01424100217;\r
+       Tue, 22 Oct 2013 09:03:46 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] perf: Clean corpus and caches in distclean, not clean\r
+In-Reply-To: <1382403338-9200-1-git-send-email-amdragon@mit.edu>\r
+References: <1382403338-9200-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16+112~g46b74be (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 22 Oct 2013 09:03:46 +0300\r
+Message-ID: <m261sphmf1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 22 Oct 2013 06:03:59 -0000\r
+\r
+On Tue, Oct 22 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Previously, we cleaned the downloaded performance corpus and the\r
+> cached indexes on 'make clean'.  This seems heavy-handed, since these\r
+> take a long time to download, unpack, and index.  They also aren't\r
+> make targets to begin with.  Move cleaning these to 'make distclean'.\r
+> This isn't exactly the right meaning of "distclean", but it's closer.\r
+> ---\r
+\r
+Good point(s). +1\r
+\r
+Tomi\r
+\r
+>  performance-test/Makefile.local | 3 ++-\r
+>  1 file changed, 2 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/performance-test/Makefile.local b/performance-test/Makefile.local\r
+> index e47219a..d97e56d 100644\r
+> --- a/performance-test/Makefile.local\r
+> +++ b/performance-test/Makefile.local\r
+> @@ -39,4 +39,5 @@ $(TXZFILE):\r
+>  download-corpus:\r
+>      wget -O ${TXZFILE} ${DEFAULT_URL}\r
+>  \r
+> -CLEAN := $(CLEAN) $(dir)/tmp.* $(dir)/log.* $(dir)/corpus $(dir)/notmuch.cache.*\r
+> +CLEAN := $(CLEAN) $(dir)/tmp.* $(dir)/log.*\r
+> +DISTCLEAN := $(dir)/corpus $(dir)/notmuch.cache.*\r
+> -- \r
+> 1.8.4.rc3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r