--- /dev/null
+Return-Path: <stlman@poczta.fm>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D101D431FC0\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:54:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.001\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.001 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id iT9xvaR9TzK7 for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Dec 2014 13:54:20 -0800 (PST)\r
+Received: from smtpo.poczta.interia.pl (smtpo.poczta.interia.pl\r
+ [217.74.65.154])\r
+ (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id CD71B431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:54:19 -0800 (PST)\r
+X-Interia-R: Interia\r
+X-Interia-R-IP: 89.65.17.18\r
+X-Interia-R-Helo: <[192.168.0.13]>\r
+Received: from [192.168.0.13] (89-65-17-18.dynamic.chello.pl [89.65.17.18])\r
+ (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by www.poczta.fm (INTERIA.PL) with ESMTPSA;\r
+ Sat, 13 Dec 2014 22:54:13 +0100 (CET)\r
+Message-ID: <548CB582.4040807@poczta.fm>\r
+Date: Sat, 13 Dec 2014 22:54:10 +0100\r
+From: Lukasz Stelmach <stlman@poczta.fm>\r
+User-Agent: Mozilla/5.0 (X11; Linux x86_64;\r
+ rv:24.0) Gecko/20100101 Thunderbird/24.8.0\r
+MIME-Version: 1.0\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: do not change users' mail agent configuration\r
+References: <1418410466-26604-1-git-send-email-stlman@poczta.fm>\r
+ <87k31vqn1h.fsf@nikula.org>\r
+In-Reply-To: <87k31vqn1h.fsf@nikula.org>\r
+X-Enigmail-Version: 1.6\r
+Content-Type: multipart/signed; micalg=pgp-sha1;\r
+ protocol="application/pgp-signature";\r
+ boundary="ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno"\r
+X-Interia-Antivirus: OK\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl;\r
+ s=biztos; t=1418507657;\r
+ bh=i7gIN3tSTyu21pHIMc2mVsl3au3iddZxzgKXHzzhUrI=;\r
+ h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Message-ID:Date:From:\r
+ User-Agent:MIME-Version:To:Subject:References:In-Reply-To:\r
+ X-Enigmail-Version:Content-Type:X-Interia-Antivirus;\r
+ b=BfBEkSdTnm96mUrPupzw7MjaiuCweld6/npVGJiSF3tEYxur08utj6iHea3GzoZ1b\r
+ REmiItDG7HCy6vtqlUzAF+OtIKmYEAwgC5qztcPFK+Dycf6ZzvsM4IWZKlfbuHDEL+\r
+ JjNBVNQcZ01L27k9ZOBc0IHd8KnFzBTCNozvZRdo=\r
+X-Mailman-Approved-At: Sun, 14 Dec 2014 02:51:22 -0800\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 13 Dec 2014 21:54:24 -0000\r
+\r
+This is an OpenPGP/MIME signed message (RFC 4880 and 3156)\r
+--ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On 13.12.2014 22:04, Jani Nikula wrote:\r
+> On Fri, 12 Dec 2014, =C5=81ukasz Stelmach <stlman@poczta.fm> wrote:\r
+>> `mail-user-agent' is defined with defcustom and may be customised\r
+>> by users. It should not be set to arbitrary values in modules.\r
+>=20\r
+> Point taken.\r
+>=20\r
+>> To make use of that configuration value call `compose-mail' which\r
+>> starts user's preferred mail composition package as selected with\r
+>> the variable `mail-user-agent' instead of notmuch's hardcoded\r
+>> `message-mail'.\r
+>=20\r
+> So your proposed change is that `notmuch-mua-mail` should start\r
+> whichever mua the user has configured in `mail-user-agent` instead of\r
+> the notmuch mail composition window, as described in the function\r
+> documentation? I don't think I like that either.\r
+>=20\r
+> Maybe we should let bind `mail-user-agent` instead?\r
+\r
+\r
+Actually `message-mail` isn't a "notmuch mail composition window" but\r
+rather a "mail composition window" implemented in message.el which is a\r
+part of Emacs. Even more, it is the default "mail composition window"\r
+in Emacs because the default value of `mail-user-agent`, as defined in\r
+simple.el, is `message-user-agent` (since Emacs 23.3 as described in a\r
+comment in `compose-mail` function therein) which causes to be launched b=\r
+y\r
+`compose-mail`.\r
+\r
+TL;DR with the mail-user-agent variable set to the default value nothing\r
+ changes for a notmuch user.\r
+\r
+>> ---\r
+>> NEWS | 10 ++++++++++\r
+>> emacs/notmuch-mua.el | 2 +-\r
+>> emacs/notmuch.el | 2 --\r
+>> 3 files changed, 11 insertions(+), 3 deletions(-)\r
+>>\r
+>> diff --git a/NEWS b/NEWS\r
+>> index 44e8d05..cf5b3c3 100644\r
+>> --- a/NEWS\r
+>> +++ b/NEWS\r
+>> @@ -64,6 +64,16 @@ Added `notmuch address` subcommand\r
+>> Emacs Interface\r
+>> ---------------\r
+>> =20\r
+>> +Fixed `mail-user-agent` handling\r
+>> +\r
+>> + The value of the mail-user-agent variable is not forcibly set to\r
+>> + `notmuch-user-agent`, regardles of how a user has customised it,\r
+>> + everytime notmuch.el is loaded. This way, someone who used for exam=\r
+ple\r
+>> + Gnus has her MUA and notmuch just as a search engine, doesn't have =\r
+her\r
+>> + configuration broken everytime notmuch.el is loaded. The user can n=\r
+ow\r
+>> + use her favourite mail composing package when replying messages in\r
+>> + notmuch too.\r
+>=20\r
+> I understand you're annoyed at the current behaviour, but please don't\r
+> pour that annoyance into notmuch NEWS. Thank you.\r
+\r
+It wasn't my intention. I wasn't even sure I should add to NEWS anything\r
+at all but the "Contributing" page says to update NEWS if a change is\r
+user visible. Considering what I wrote above, do you think it is visible?=\r
+\r
+\r
+=20\r
+> BR,\r
+> Jani.\r
+>=20\r
+>=20\r
+>> +\r
+>> Use the `j` key to access saved searches from anywhere in notmuch\r
+>> =20\r
+>> `j` is now globally bound to `notmuch-jump`, which provides fast,\r
+>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+>> index 2c58886..f02c7b5 100644\r
+>> --- a/emacs/notmuch-mua.el\r
+>> +++ b/emacs/notmuch-mua.el\r
+>> @@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."\r
+>> (push (cons 'From (concat\r
+>> (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) =\r
+other-headers))\r
+>> =20\r
+>> - (apply #'message-mail to subject other-headers other-args)\r
+>> + (apply #'compose-mail to subject other-headers other-args)\r
+>> (message-sort-headers)\r
+>> (message-hide-headers)\r
+>> (set-buffer-modified-p nil)\r
+>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+>> index 218486a..80cab57 100644\r
+>> --- a/emacs/notmuch.el\r
+>> +++ b/emacs/notmuch.el\r
+>> @@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."\r
+>> (switch-to-buffer first))\r
+>> (notmuch))))\r
+>> =20\r
+>> -(setq mail-user-agent 'notmuch-user-agent)\r
+>> -\r
+>> (provide 'notmuch)\r
+>> =20\r
+>> ;; After provide to avoid loops if notmuch was require'd via notmuch-=\r
+init-file.\r
+>> --=20\r
+>> 2.0.4\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+>=20\r
+\r
+\r
+--=20\r
+By=C5=82o mi bardzo mi=C5=82o. Twoje oczy lubi=C4=85 mn=\r
+ie\r
+>=C5=81ukasz< i to mnie zgubi (c)SNL=\r
+\r
+\r
+REKLAMA: http://ars-fabrica.eu/ sklep z r=C4=99kodzie=C5=82em\r
+\r
+\r
+--ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+Content-Description: OpenPGP digital signature\r
+Content-Disposition: attachment; filename="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2\r
+Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/\r
+\r
+iQEcBAEBAgAGBQJUjLWCAAoJEAC2l2xjkdNxPPUIAK7AkzXhtzZvblz29RnvmiNU\r
+FDTpf3RxmqDNCuUcQ6ZumPZbyrgHTtIPAiOVEv+KFH2oIZDbJDGmwKl6bAkWqboP\r
+S+WJbkLqXK5R4pFqEAuE68sZMXjOc861qpsadHC1RX/Cys4K+ULhNljpcmCTkUpL\r
+AVUJcPOdigjYANlqA+4TwAHMnfOONVLHJfv/K5r9E/D1vqW3cVCg2acD2v1mZOma\r
+3y1aR6OA2JPd0tZZxB13emHCr89QFYOF3O5yPvk4lr1mApUt7leZZJpfZTjS6N6+\r
+2Jc7KZY8jjagB6j5jl6LT/XMahXa4v//tQTh+FTCoPLkenee9PFxgS3iAm6ZiWI=\r
+=kyaC\r
+-----END PGP SIGNATURE-----\r
+\r
+--ncKFw1WNDiTR0l9uBgbTibrq7thAfUHno--\r
projects / notmuch-archives.git / commitdiff