Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()

diff --git a/a9/69135b6e986ac8c08f9eedbc9f314510501f0c b/a9/69135b6e986ac8c08f9eedbc9f314510501f0c
new file mode 100644 (file)
index 0000000..57db9c0
--- /dev/null
+++ b/a9/69135b6e986ac8c08f9eedbc9f314510501f0c
@@ -0,0 +1,146 @@
+Return-Path: <polatel@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0B1D2431FC7\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HSDXYcFTx-DV for <notmuch@notmuchmail.org>;\r
+       Tue, 21 May 2013 07:46:32 -0700 (PDT)\r
+Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com\r
+       [209.85.215.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8D356431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:32 -0700 (PDT)\r
+Received: by mail-ea0-f175.google.com with SMTP id h10so453655eaj.34\r
+       for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:31 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:from:to:cc:subject:message-id:mail-followup-to:references\r
+       :mime-version:content-type:content-disposition:in-reply-to\r
+       :organization:user-agent;\r
+       bh=C2zmDtZNk03NQZ3kPsSnKubxEICY+i8qBo1CYeOzhOo=;\r
+       b=TpEMwmONavMAvCuqNROvLDocQc7/1Cv8qBov7xD1iEkXyLsqCvlSEbpkOg2qE79Bl4\r
+       c0jisNfmQseGphuB9nfFY9kayhQnwVLsR7dhL8yuPpGpeQB2eqRX/kz7iazqtnE7Om7e\r
+       jKR9NbALMbPqrNUHXhBclCstK2/mUArulmzBqba0D1sCXMqFGVu25w8/y1Hbrp4Prckl\r
+       Ev8kxknx7H+OWGmCHIhLKJGaAjaX8dNGue8vke7rbROZ8DL0o3qXITRmbZOotvvzlM0X\r
+       El3LtHFpyO6jnuXJTXGihEzw+vHqbrTTJ5WdqHVk7kONwVJDWgq96PLjteUBPqBIvlor\r
+       IwUw==\r
+X-Received: by 10.15.22.135 with SMTP id f7mr7233454eeu.29.1369147591340;\r
+       Tue, 21 May 2013 07:46:31 -0700 (PDT)\r
+Received: from localhost ([88.234.58.113])\r
+       by mx.google.com with ESMTPSA id x41sm3965936eey.17.2013.05.21.07.46.29\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\r
+       Tue, 21 May 2013 07:46:30 -0700 (PDT)\r
+Date: Tue, 21 May 2013 17:46:59 +0300\r
+From: Ali Polatel <polatel@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()\r
+Message-ID: <20130521144659.GA6002@hayalet>\r
+Mail-Followup-To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+       Felipe Contreras <felipe.contreras@gmail.com>,\r
+       notmuch@notmuchmail.org\r
+References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>\r
+       <m2vc6c4dtq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; micalg=pgp-sha1;\r
+       protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT"\r
+Content-Disposition: inline\r
+In-Reply-To: <m2vc6c4dtq.fsf@guru.guru-group.fi>\r
+Organization: Pink Floyd\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 May 2013 14:46:37 -0000\r
+\r
+\r
+--X1bOJ3K7DJ5YkBrT\r
+Content-Type: text/plain; charset=us-ascii; format=flowed\r
+Content-Disposition: inline\r
+\r
+2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>:\r
+>On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>\r
+>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are\r
+>> loaded lazily, so nobody would notice unless they try\r
+>> 'query::count_messages'.\r
+>>\r
+>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\r
+>\r
+>This patch could be pushed on it's own, but someone (like Ali) could\r
+>comment on the change as searches on both UINT2FIX() & UINT2NUM()\r
+>provides (IMH) insatisfactory results...\r
+\r
+LGTM.\r
+\r
+My bad, there's no such thing as UINT2FIX().\r
+Yet, what's wrong with UINT2NUM()?\r
+\r
+The description looks like:\r
+"...take an unsigned int and convert it to a FIXNUM object if it will fit;\r
+otherwise, convert to a Bignum object..."\r
+\r
+Besides ruby-1.8 has it and that's the oldest version I was willing to\r
+support. (If you have some free time, please confirm this because I may\r
+not be remembering correctly.)\r
+\r
+>Tomi\r
+\r
+               -alip\r
+\r
+>\r
+>> ---\r
+>>  bindings/ruby/query.c | 2 +-\r
+>>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>>\r
+>> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c\r
+>> index e5ba1b7..1658ede 100644\r
+>> --- a/bindings/ruby/query.c\r
+>> +++ b/bindings/ruby/query.c\r
+>> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)\r
+>>       * (function may return 0 after printing a message)\r
+>>       * Thus there is nothing we can do here...\r
+>>       */\r
+>> -    return UINT2FIX(notmuch_query_count_messages(query));\r
+>> +    return UINT2NUM(notmuch_query_count_messages(query));\r
+>>  }\r
+>> --\r
+>> 1.8.3.rc3.286.g3d43083\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+--X1bOJ3K7DJ5YkBrT\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2.0.19 (GNU/Linux)\r
+\r
+iEYEARECAAYFAlGbiOAACgkQQU4yORhF8iBBGACdEaM899S+FCDWzTKnT4rEUsho\r
+yHsAn1kzSlkWOacI25lREHn+q6boc6el\r
+=FME9\r
+-----END PGP SIGNATURE-----\r
+\r
+--X1bOJ3K7DJ5YkBrT--\r