Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

diff --git a/1a/f6fb10bfcd84d85788cfea22012f3edc1a9a64 b/1a/f6fb10bfcd84d85788cfea22012f3edc1a9a64
new file mode 100644 (file)
index 0000000..e870388
--- /dev/null
+++ b/1a/f6fb10bfcd84d85788cfea22012f3edc1a9a64
@@ -0,0 +1,81 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4EB67431FD0\r
+       for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EWs+5uph38Qw for <notmuch@notmuchmail.org>;\r
+       Mon, 31 Oct 2011 15:08:05 -0700 (PDT)\r
+Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com\r
+       [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9E29C431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:05 -0700 (PDT)\r
+Received: by faai28 with SMTP id i28so6781851faa.26\r
+       for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:04 -0700 (PDT)\r
+Received: by 10.223.14.3 with SMTP id e3mr32907327faa.25.1320098884201;\r
+       Mon, 31 Oct 2011 15:08:04 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi.\r
+       [80.220.92.23])\r
+       by mx.google.com with ESMTPS id j5sm40493434faf.14.2011.10.31.15.08.01\r
+       (version=SSLv3 cipher=OTHER); Mon, 31 Oct 2011 15:08:03 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in\r
+       search results\r
+In-Reply-To: <87fwi86dky.fsf@servo.finestructure.net>\r
+References: <cover.1320093940.git.jani@nikula.org>\r
+       <87fwi86dky.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.9+44~ga312b1d (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+Date: Tue, 01 Nov 2011 00:07:59 +0200\r
+Message-ID: <87obwwlsqo.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: amdragon@mit.edu\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 31 Oct 2011 22:08:06 -0000\r
+\r
+On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> Hi, Jani.  Thanks for working on this.  This should also be valuable for\r
+> vim users.\r
+\r
+Thanks for your interest! :)\r
+\r
+> In order to push forward with this, though, I think we really need to\r
+> have a complete unit test for this new functionality.  We usually like\r
+> to see units tests that describe and then test for the new functionality\r
+> you wish to add, followed by the patches that provide the new\r
+> functionality.  Lots of good tests for new functionality being proposed\r
+> here shouldn't be too difficult to work out ahead of time.\r
+\r
+Right. I'd just like to make sure the approach I've taken (particularly\r
+patch 1 in the set as it touches the lib) is acceptable before spending\r
+time on testing and documentation etc. Indeed patches 1 and 2 changed\r
+fundamentally between v1 and v2 after some chats on IRC. If the comments\r
+now are favourable, I'll write the tests and documentation. (Though I\r
+guess I have to admit the tests would've been beneficial to me already\r
+now...)\r
+\r
+BR,\r
+Jani.\r