Re: [PATCH] lib: Simplify close and codify aborting atomic section

diff --git a/97/1c4232a11900c3d68ba316065c3b38ff01535e b/97/1c4232a11900c3d68ba316065c3b38ff01535e
new file mode 100644 (file)
index 0000000..2416f70
--- /dev/null
+++ b/97/1c4232a11900c3d68ba316065c3b38ff01535e
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 20185431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 13:13:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id K9Qn-FsvJc4z for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Sep 2014 13:13:38 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 442E8431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 13:13:38 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XWswS-0001y7-Kk; Wed, 24 Sep 2014 17:13:36 -0300\r
+Received: (nullmailer pid 6974 invoked by uid 1000); Wed, 24 Sep 2014\r
+       20:13:31 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section\r
+In-Reply-To: <20140924194413.GC20130@odin.tremily.us>\r
+References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
+       <20140922165954.GI20827@odin.tremily.us>\r
+       <20140922185050.GB7970@csail.mit.edu>\r
+       <20140922190022.GO20827@odin.tremily.us>\r
+       <87iokc28mg.fsf@maritornes.cs.unb.ca>\r
+       <20140924181844.GB20130@odin.tremily.us>\r
+       <87d2ak253z.fsf@maritornes.cs.unb.ca>\r
+       <20140924194413.GC20130@odin.tremily.us>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 24 Sep 2014 22:13:31 +0200\r
+Message-ID: <87a95o22vo.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Sep 2014 20:13:42 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+> On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote:\r
+>> I think the fact that you have to close the notmuch database (when\r
+>> not using begin/end atomic) to get a commit is surprising for many\r
+>> people, so it would be nice to make that clearer somehow.\r
+>\r
+> It looks like Xapian is GPLv2+, so we should just be able to\r
+> copy/paste/edit the line I quoted from the Xapian docs.\r
+>\r
+> Cheers,\r
+> Trevor\r
+\r
+I think it would be better to write our own, not because of licensing\r
+issues, but because the user of the notmuch API won't know what a xapian\r
+commit is.\r
+\r
+d\r