Re: [PATCH] Actually close the xapian database in notmuch_database_close

diff --git a/53/f91342b5cf5ed261445f9b51287bcf96c338e8 b/53/f91342b5cf5ed261445f9b51287bcf96c338e8
new file mode 100644 (file)
index 0000000..e4d5977
--- /dev/null
+++ b/53/f91342b5cf5ed261445f9b51287bcf96c338e8
@@ -0,0 +1,78 @@
+Return-Path: <olly@survex.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E950A431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 13:20:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sB89M8KcWBs3 for <notmuch@notmuchmail.org>;\r
+       Thu,  1 Mar 2012 13:20:47 -0800 (PST)\r
+Received: from atreus.tartarus.org (atreus.tartarus.org [80.252.125.10])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 49FE0431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  1 Mar 2012 13:20:47 -0800 (PST)\r
+Received: from olly by atreus.tartarus.org with local (Exim 4.69)\r
+       (envelope-from <olly@survex.com>)\r
+       id 1S3DQX-0001YB-57; Thu, 01 Mar 2012 21:20:41 +0000\r
+Date: Thu, 1 Mar 2012 21:20:41 +0000\r
+From: Olly Betts <olly@survex.com>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Subject: Re: [PATCH] Actually close the xapian database in\r
+       notmuch_database_close\r
+Message-ID: <20120301212040.GW24964@survex.com>\r
+References:\r
+ <1330507157-22859-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1330507157-22859-2-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <20120229154833.GB772@mit.edu> <20120229211922.GQ24964@survex.com>\r
+       <20120229221754.GD772@mit.edu>\r
+       <20120301065930.5076.72748@thinkbox.jade-hamburg.de>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <20120301065930.5076.72748@thinkbox.jade-hamburg.de>\r
+User-Agent: Mutt/1.5.18 (2008-05-17)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 01 Mar 2012 21:20:48 -0000\r
+\r
+On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:\r
+> Olly wrote:\r
+> >It is hard to say if calling close() is actually useful here from just\r
+> >seeing the patch.\r
+> \r
+> Huh? I provided a test case...\r
+\r
+I only saw the part of the patch Austin quoted in the mail he cc-ed to\r
+me.\r
+\r
+> Quoting Austin Clements (2012-02-29 23:17:54)\r
+> >Also, since close could throw an exception, it should get wrapped in a\r
+> >try/catch like flush currently is.\r
+> \r
+> My interpretation of [0] was that Xapian::Database::close() does not\r
+> throw any exceptions.\r
+\r
+Sadly there's not full documentation of exceptions which can be thrown \r
+by a particular method.\r
+\r
+Cheers,\r
+    Olly\r