--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id BD043431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 5 Apr 2014 18:24:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rfuMv+UT8XwF for <notmuch@notmuchmail.org>;\r
+ Sat, 5 Apr 2014 18:24:32 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (dmz-mailsec-scanner-7.mit.edu\r
+ [18.7.68.36])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 9FE67431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 5 Apr 2014 18:24:30 -0700 (PDT)\r
+X-AuditID: 12074424-f79e26d000000c70-61-5340accb4cbe\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ (using TLS with cipher AES256-SHA (256/256 bits))\r
+ (Client did not present a certificate)\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id F7.FA.03184.BCCA0435; Sat, 5 Apr 2014 21:24:27 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s361ORNH030356; \r
+ Sat, 5 Apr 2014 21:24:27 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s361OPWb019432\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Sat, 5 Apr 2014 21:24:26 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1WWbov-000786-If; Sat, 05 Apr 2014 21:24:25 -0400\r
+Date: Sat, 5 Apr 2014 21:24:25 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to\r
+ plists\r
+Message-ID: <20140406012425.GF15472@mit.edu>\r
+References: <1396733065-32602-1-git-send-email-markwalters1009@gmail.com>\r
+ <1396733065-32602-5-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1396733065-32602-5-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j29xiHY4O1fG4vVc3ksrt+cyezA\r
+ 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcxcsZ254LxcxfpTE9kaGKdJdDFyckgImEhM\r
+ mfGbHcIWk7hwbz1bFyMXh5DAbCaJt8cnMYMkhAQ2MEo0Hk2HSJxikpg6ZSM7hLOEUeLWrGVM\r
+ XYwcHCwCKhLvNkqCNLAJaEhs27+cEcQWEdCRuH1oAdgGZgFpiW+/m5lAbGGBMIm7fX/ZQGxe\r
+ oJpdPXtYIGZ2Mkq8a5rNDJEQlDg58wkLRLOWxI1/L8F2gQxa/o8DJMwp4CVx+9M3sF2iQCdM\r
+ ObmNbQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI11wvN7NELzWldBMj\r
+ KKjZXVR2MDYfUjrEKMDBqMTDW5HjECzEmlhWXJl7iFGSg0lJlLdrBlCILyk/pTIjsTgjvqg0\r
+ J7X4EKMEB7OSCO+TIKAcb0piZVVqUT5MSpqDRUmc9621VbCQQHpiSWp2ampBahFMVoaDQ0mC\r
+ d8ZqoEbBotT01Iq0zJwShDQTByfIcB6g4Q0gNbzFBYm5xZnpEPlTjIpS4rwuq4ASAiCJjNI8\r
+ uF5Y0nnFKA70ijBvM0g7DzBhwXW/AhrMBDI4zA5kcEkiQkqqgVHl5CfhBYyzXCxNXHj6soQy\r
+ ZTM2hM6ewu38pmJCwXlOzv2vVtlXtCwP0Xpw//DT0P8C/8MWuW4NmjI3n/2zzg5/t8MJtqwx\r
+ r7a665kb7hfl1J/T3MOwra1PoLe1X/7a2cbZ+dcvLpN3DK3ZcjknzWvi2Yt/nV52tj0Qfq9x\r
+ 5ZR+yYVTvht0apVYijMSDbWYi4oTAfgMpcEVAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Apr 2014 01:24:43 -0000\r
+\r
+Quoth Mark Walters on Apr 05 at 10:24 pm:\r
+> Switching notmuch-hello-insert-buttons to plists means we can easily\r
+> pass extra options through to the buttons.\r
+> ---\r
+> emacs/notmuch-hello.el | 33 +++++++++++++++++++--------------\r
+> 1 file changed, 19 insertions(+), 14 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index c729af2..aa40e6f 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -425,7 +425,9 @@ (defun notmuch-hello-query-counts (query-list &rest options)\r
+> these is a plist but other options are available for backwards\r
+> compatibility: see notmuch-saved-search-get for details.\r
+> \r
+> -The result is the list of elements of the form (NAME QUERY COUNT).\r
+> +The result is a list of plists each of which includes the\r
+> +pairs :name NAME, :query QUERY and :count COUNT, together with\r
+> +any pairs in the original saved-search.\r
+\r
+"Pair" can be synonymous with "cons", which is not what you mean here.\r
+"Properties"?\r
+\r
+> \r
+> The values :show-empty-searches, :filter and :filter-count from\r
+> options will be handled as specified for\r
+> @@ -455,23 +457,26 @@ (defun notmuch-hello-query-counts (query-list &rest options)\r
+> #'identity\r
+> (mapcar\r
+> (lambda (elem)\r
+> - (let ((name (notmuch-saved-search-get elem :name))\r
+> - (search-query (notmuch-saved-search-get elem :query))\r
+> - (message-count (prog1 (read (current-buffer))\r
+> + (let* ((elem-plist (notmuch-hello-saved-search-to-plist elem))\r
+> + (search-query (plist-get elem-plist :query))\r
+> + (filtered-query (notmuch-hello-filtered-query\r
+> + search-query (plist-get options :filter)))\r
+> + (message-count (prog1 (read (current-buffer))\r
+> (forward-line 1))))\r
+> (and (or (plist-get options :show-empty-searches) (> message-count 0))\r
+> - (list name (notmuch-hello-filtered-query\r
+> - search-query (plist-get options :filter))\r
+> - message-count))))\r
+> + (setq elem-plist (plist-put elem-plist :query filtered-query))\r
+\r
+This technically works, but `setq' is a strange thing to see in an\r
+`and'. But the problem isn't the `setq'; it's that crazy `and'. I'd\r
+replace the `and' with `when', keep the `setq' and `plist-put' in the\r
+body, and squint a lot less at this code.\r
+\r
+> + (plist-put elem-plist :count message-count))))\r
+> query-list))))\r
+> \r
+> (defun notmuch-hello-insert-buttons (searches)\r
+> "Insert buttons for SEARCHES.\r
+> \r
+> -SEARCHES must be a list containing lists of the form (NAME QUERY COUNT), where\r
+> -QUERY is the query to start when the button for the corresponding entry is\r
+> -activated. COUNT should be the number of messages matching the query.\r
+> -Such a list can be computed with `notmuch-hello-query-counts'."\r
+> +SEARCHES must be a list of plists each of which should contain at\r
+> +least pairs for :name NAME :query QUERY and :count COUNT, where\r
+\r
+Same comment about "pairs".\r
+\r
+> +QUERY is the query to start when the button for the corresponding\r
+> +entry is activated, and COUNT should be the number of messages\r
+> +matching the query. Such a plist can be computed with\r
+> +`notmuch-hello-query-counts'."\r
+> (let* ((widest (notmuch-hello-longest-label searches))\r
+> (tags-and-width (notmuch-hello-tags-per-line widest))\r
+> (tags-per-line (car tags-and-width))\r
+> @@ -489,9 +494,9 @@ (defun notmuch-hello-insert-buttons (searches)\r
+> (when elem\r
+> (if (> column-indent 0)\r
+> (widget-insert (make-string column-indent ? )))\r
+> - (let* ((name (first elem))\r
+> - (query (second elem))\r
+> - (msg-count (third elem)))\r
+> + (let* ((name (plist-get elem :name))\r
+> + (query (plist-get elem :query))\r
+> + (msg-count (plist-get elem :count)))\r
+> (widget-insert (format "%8s "\r
+> (notmuch-hello-nice-number msg-count)))\r
+> (widget-create 'push-button\r
projects / notmuch-archives.git / commitdiff