Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t

diff --git a/ee/b04acc18fadf3589455037b4ec54bcb561cf4e b/ee/b04acc18fadf3589455037b4ec54bcb561cf4e
new file mode 100644 (file)
index 0000000..8b40c4f
--- /dev/null
+++ b/ee/b04acc18fadf3589455037b4ec54bcb561cf4e
@@ -0,0 +1,88 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 4F64F6DE0C3A\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Dec 2015 17:20:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.312\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.312 tagged_above=-999 required=5 tests=[AWL=0.239,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id B1xpn3UnaqHs for <notmuch@notmuchmail.org>;\r
+ Sat, 12 Dec 2015 17:20:19 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 68C646DE0B4B\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Dec 2015 17:20:19 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1a7vKb-0008Mh-KL; Sat, 12 Dec 2015 20:20:09 -0500\r
+Received: (nullmailer pid 18544 invoked by uid 1000);\r
+ Sun, 13 Dec 2015 01:20:11 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t\r
+In-Reply-To: <87mvtgfws4.fsf@alice.fifthhorseman.net>\r
+References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1449718786-28000-8-git-send-email-dkg@fifthhorseman.net>\r
+ <m21tas7ifa.fsf@guru.guru-group.fi> <87mvtgfws4.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 12 Dec 2015 21:20:11 -0400\r
+Message-ID: <87d1ubdu0k.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Dec 2015 01:20:21 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> On Fri 2015-12-11 17:02:33 -0500, Tomi Ollila wrote:\r
+>> The above code finds gpg/gpg2 (when called w/ these args) from\r
+>> _CS_PATH (seems to be /bin:/usr/bin by default in linux (tried to\r
+>> look how this set in *BSD -- initially it looks like /usr/local/bin\r
+>> not included but... maybe we let them to complain if this is the case\r
+>> ... :/)\r
+>> ... anyway, the full found path is not set anywhere -- how is it found\r
+>> when used (exec*p() using $PATH? :O)\r
+>\r
+> Hm, according to exec(3):\r
+>\r
+>    Special semantics for execlp() and execvp()\r
+>        The execlp(), execvp(), and execvpe() functions duplicate the\r
+>        actions of the shell in searching for an executable file if the\r
+>        specified filename does not contain a slash (/) character.  The\r
+>        file is sought in the colon-separated list of directory pathnames\r
+>        specified in the PATH environment variable.  If this variable\r
+>        isn't defined, the path list defaults to the current directory\r
+>        followed by the list of directories returned by\r
+>        confstr(_CS_PATH).  (This confstr(3) call typically returns the\r
+>        value "/bin:/usr/bin".)\r
+>\r
+> So this code probably also ought to be searching $PATH as well.  yuck.\r
+> You'd think there would be a commonly-available function for doing this\r
+> specific check without having to actually try to exec() something.\r
+\r
+Without weighing in on the advisibility of searching for gpg in $PATH,\r
+there is a glib function g_find_program_in_path. We're already linking\r
+to glib (because of gmime mainly, but it's used other places as well).\r
+\r
+The other point that occurs to me is that libgpgme solves this same\r
+problem in src/posix-util.c. It also seems to search path, at least\r
+optionally, although only if it cannot find gpgconf.\r
+\r