Re: [PATCH v4 02/16] Move crypto.c into libutil

diff --git a/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe b/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe
new file mode 100644 (file)
index 0000000..a286f29
--- /dev/null
+++ b/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe
@@ -0,0 +1,95 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D57636DE3451\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 01:02:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.562\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.562 tagged_above=-999 required=5 tests=[AWL=-0.090,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 2uYiSzlX-Aik for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Aug 2016 01:01:56 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 4FCE26DE336E\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 01:01:55 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 5C19610007F;\r
+ Sat, 13 Aug 2016 11:01:26 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>,\r
+ Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil\r
+In-Reply-To: <874m6qqznr.fsf@maritornes.cs.unb.ca>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>\r
+ <874m6qqznr.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.22+61~geeecb9e (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 13 Aug 2016 11:01:26 +0300\r
+Message-ID: <m2shu99jxl.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 13 Aug 2016 08:02:05 -0000\r
+\r
+On Fri, Aug 12 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>> +++ b/util/crypto.c\r
+>> @@ -0,0 +1,138 @@\r
+>\r
+>> +#include "notmuch.h"\r
+>\r
+> It feels wrong to me for a file in util/ to include notmuch.h.  It seems\r
+> the same situation holds with search-path.h.  There it seems we use\r
+> notmuch_bool_t (although I'm not convinced that's the right return\r
+> type). If that's the only reason maybe we should either factor out the\r
+> definition or just return ints.\r
+\r
+util/search-path.c is easy, change to int or bool (and include stdbool.h,\r
+as parse-time-string.c does)\r
+\r
+util/crypto.c is harder. it uses many more \bnotmuch_.* types. perhaps this\r
+could be moved to lib/ instead ?\r
+\r
+\r
+\r
+>\r
+>> +/* Create a PKCS7 context (GMime 2.6) */\r
+>> +static notmuch_crypto_context_t *\r
+>> +create_pkcs7_context (notmuch_crypto_t *crypto)\r
+>> +{\r
+>> +    notmuch_crypto_context_t *pkcs7ctx;\r
+>\r
+> I guess this is leftover, and causes the build failure.\r
+>\r
+>> +\r
+>> +#include "notmuch.h"\r
+>\r
+> Same questions notmuch.h here.\r
+>\r
+> d\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> https://notmuchmail.org/mailman/listinfo/notmuch\r