Re: [PATCH] test/emacs: globally force the html renderer to html2text

diff --git a/34/d2462d5d0022b37a7c91f3977e42961ecb48c3 b/34/d2462d5d0022b37a7c91f3977e42961ecb48c3
new file mode 100644 (file)
index 0000000..d1b1d1e
--- /dev/null
+++ b/34/d2462d5d0022b37a7c91f3977e42961ecb48c3
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 199D2431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 21 Sep 2014 08:25:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0Uv2nD50o8Lu for <notmuch@notmuchmail.org>;\r
+       Sun, 21 Sep 2014 08:25:20 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8DD97431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 21 Sep 2014 08:25:20 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E3A2E100033;\r
+       Sun, 21 Sep 2014 18:24:53 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test/emacs: globally force the html renderer to html2text\r
+In-Reply-To: <1411191695-21933-1-git-send-email-david@tethera.net>\r
+References: <1411191695-21933-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 21 Sep 2014 18:24:53 +0300\r
+Message-ID: <m2bnq9c7y2.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 21 Sep 2014 15:25:28 -0000\r
+\r
+On Sat, Sep 20 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Previously we did this for a single test, but some other proposed\r
+> tests ( id:1398105468-14317-3-git-send-email-amdragon@mit.edu ) show\r
+> similar breakage when switching renderers.\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+PS: in that file we don't seem to have unified style with comment\r
+capitalization, trailing periods and newlines between comment and code.\r
+\r
+> ---\r
+>  test/T310-emacs.sh | 2 +-\r
+>  test/test-lib.el   | 5 +++++\r
+>  2 files changed, 6 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh\r
+> index ac966e5..c302402 100755\r
+> --- a/test/T310-emacs.sh\r
+> +++ b/test/T310-emacs.sh\r
+> @@ -483,7 +483,7 @@ test_expect_equal_file OUTPUT EXPECTED\r
+>  test_begin_subtest "Reply within emacs to an html-only message"\r
+>  add_message '[content-type]="text/html"' \\r
+>          '[body]="Hi,<br />This is an <b>HTML</b> test message.<br /><br />OK?"'\r
+> -test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer 'html2text))\r
+> +test_emacs "(let ((message-hidden-headers '()))\r
+>          (notmuch-show \"id:${gen_msg_id}\")\r
+>          (notmuch-show-reply)\r
+>          (test-output))"\r
+> diff --git a/test/test-lib.el b/test/test-lib.el\r
+> index 36afe63..bbc03cb 100644\r
+> --- a/test/test-lib.el\r
+> +++ b/test/test-lib.el\r
+> @@ -181,3 +181,8 @@ nothing."\r
+>  ;; suite\r
+>  (setq notmuch-tag-deleted-formats\r
+>        '((".*" nil)))\r
+> +\r
+> +;; force a common html renderer, to avoid test variations between\r
+> +;; environments\r
+> +\r
+> +(setq mm-text-html-renderer 'html2text)\r
+> -- \r
+> 2.1.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r