Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses

diff --git a/34/91603e61810ecd6ad9f359ff171c7ebf7aad86 b/34/91603e61810ecd6ad9f359ff171c7ebf7aad86
new file mode 100644 (file)
index 0000000..6b517e9
--- /dev/null
+++ b/34/91603e61810ecd6ad9f359ff171c7ebf7aad86
@@ -0,0 +1,130 @@
+Return-Path: <sojka@merica.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8DBCD431FCF\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Nov 2014 12:45:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.224\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.224 tagged_above=-999 required=5\r
+       tests=[DATE_IN_PAST_03_06=1.076, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RxU85UFhStSJ for <notmuch@notmuchmail.org>;\r
+       Tue,  4 Nov 2014 12:45:30 -0800 (PST)\r
+Received: from relay.felk.cvut.cz (relay.felk.cvut.cz [147.32.80.7])\r
+       by olra.theworths.org (Postfix) with ESMTP id CBC76431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Nov 2014 12:45:29 -0800 (PST)\r
+Received: from control.felk.cvut.cz (control.felk.cvut.cz [147.32.87.4])\r
+       by relay.felk.cvut.cz (8.14.9/8.14.9) with ESMTP id sA4FZxMl036846;\r
+       Tue, 4 Nov 2014 16:35:59 +0100 (CET) (envelope-from sojka@merica.cz)\r
+Received: from CONTROL/SpoolDir by control.felk.cvut.cz (Mercury 1.48);\r
+       4 Nov 14 16:36:00 +0100\r
+Received: from SpoolDir by CONTROL (Mercury 1.48); 4 Nov 14 16:35:54 +0100\r
+Received: from rtime.felk.cvut.cz (147.32.86.92) by control.felk.cvut.cz\r
+       (Mercury 1.48) with ESMTP; 4 Nov 14 16:35:53 +0100\r
+Received: from localhost ([127.0.0.1] helo=steelpick.2x.cz)\r
+       by rtime.felk.cvut.cz with esmtp (Exim 4.80)\r
+       (envelope-from <sojka@merica.cz>)\r
+       id 1Xlg9A-0004xP-Hk; Tue, 04 Nov 2014 16:35:52 +0100\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.84)\r
+       (envelope-from <sojka@merica.cz>)\r
+       id 1XlcPB-0002Wr-G1; Tue, 04 Nov 2014 12:36:09 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses\r
+In-Reply-To: <87a947monn.fsf@maritornes.cs.unb.ca>\r
+References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415058622-21162-9-git-send-email-sojkam1@fel.cvut.cz>\r
+       <87a947monn.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 04 Nov 2014 12:36:09 +0100\r
+Message-ID: <87a947mc46.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-FELK-MailScanner-Information: \r
+X-MailScanner-ID: sA4FZxMl036846\r
+X-FELK-MailScanner: Found to be clean\r
+X-FELK-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,\r
+       score=1.093, required 6, BAYES_00 -0.50, DATE_IN_PAST_03_06 1.59,\r
+       HEADER_FROM_DIFFERENT_DOMAINS 0.00)\r
+X-FELK-MailScanner-SpamScore: s\r
+X-FELK-MailScanner-From: sojka@merica.cz\r
+X-FELK-MailScanner-Watermark: 1415720167.12737@Y0Rgo6YZHp5B4GF9H3aRWg\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Nov 2014 20:45:38 -0000\r
+\r
+On Tue, Nov 04 2014, David Bremner wrote:\r
+> Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+>\r
+>>  \r
+>> +/* Returns TRUE iff name and addr is duplicate. */\r
+>\r
+> If you're revising this patch, it would be good to mention the side\r
+> effect of this function.\r
+>\r
+>> -process_address_list (const search_context_t *ctx, InternetAddressList *list)\r
+>> +process_address_list (const search_context_t *ctx,\r
+>> +                 InternetAddressList *list)\r
+>\r
+> It probably doesn't make any difference, but this looks like a needless\r
+> whitespace change.\r
+>\r
+> This function definitely needs some comment / pointer to\r
+> documention. And probably not to have _my in the name.\r
+>\r
+>> +static void\r
+>> +_my_talloc_free_for_g_hash (void *ptr)\r
+>> +{\r
+>> +    talloc_free (ptr);\r
+>> +}\r
+>> +\r
+>\r
+> I don't understand the name of the next subtest\r
+>\r
+>> +test_begin_subtest "No --output"\r
+>> +notmuch address --output=sender --output=recipients '*' >OUTPUT\r
+\r
+This should be "notmuch address '*' >OUTPUT". I'll fix that.\r
+\r
+>> +# Use EXPECTED from previous subtest\r
+>> +test_expect_equal_file OUTPUT EXPECTED\r
+>> +\r
+>> +\r
+>> +test_done\r
+>\r
+> nitpick, extra blank lines\r
+>\r
+> So, AIUI, this is all of the series proposed for 0.19. \r
+\r
+Agreed.\r
+\r
+> It looks close to OK to me, modulo some minor style nits. One\r
+> anonymous commentator on IRC mentioned the use of module scope\r
+> variables, I guess in patch 6/10. I'm not sure of a better solution,\r
+> but it's true in a perfect world we wouldn't have module local state.\r
+\r
+A possible solution would be fill in common_options structure\r
+programmatically, but this would make the code much less readable. I can\r
+think of a few other solutions but none of them would fit into "perfect\r
+world" :)\r
+\r
+I'll send updated patches in the evening (CET timezone).\r
+\r
+Thanks\r
+-Michal\r