--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1EA97431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 5 Apr 2014 22:32:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Tj9qif13kcsG for <notmuch@notmuchmail.org>;\r
+ Sat, 5 Apr 2014 22:32:48 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id C3FB8431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 5 Apr 2014 22:32:47 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WWfh6-0003kf-DU; Sun, 06 Apr 2014 06:32:45 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WWfh6-0003Ry-36; Sun, 06 Apr 2014 06:32:36 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 5/5] emacs: Add a sort-order option to saved-searches\r
+In-Reply-To: <20140406013029.GG15472@mit.edu>\r
+References: <1396733065-32602-1-git-send-email-markwalters1009@gmail.com>\r
+ <1396733065-32602-6-git-send-email-markwalters1009@gmail.com>\r
+ <20140406013029.GG15472@mit.edu>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 06 Apr 2014 06:32:35 +0100\r
+Message-ID: <87sipruioc.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 95a750182b32e53587c6ff5a3d2ab059 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Apr 2014 05:32:56 -0000\r
+\r
+\r
+Hi\r
+\r
+On Sun, 06 Apr 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Mark Walters on Apr 05 at 10:24 pm:\r
+>> This adds a sort-order option to saved-searches, stores it in the\r
+>> saved-search buttons (widgets), and uses the stored value when the\r
+>> button is pressed.\r
+>> \r
+>> Storing the sort-order in the widget was suggested by Jani in\r
+>> id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.jani@nikula.org.\r
+>> ---\r
+>> emacs/notmuch-hello.el | 11 ++++++++++-\r
+>> emacs/notmuch-lib.el | 7 ++++++-\r
+>> 2 files changed, 16 insertions(+), 2 deletions(-)\r
+>> \r
+>> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+>> index aa40e6f..6a28372 100644\r
+>> --- a/emacs/notmuch-hello.el\r
+>> +++ b/emacs/notmuch-hello.el\r
+>> @@ -364,7 +364,8 @@ (defun notmuch-hello-reflect (list ncols)\r
+>> (defun notmuch-hello-widget-search (widget &rest ignore)\r
+>> (notmuch-search (widget-get widget\r
+>> :notmuch-search-terms)\r
+>> - notmuch-search-oldest-first))\r
+>> + (widget-get widget\r
+>> + :notmuch-search-oldest-first)))\r
+>> \r
+>> (defun notmuch-saved-search-count (search)\r
+>> (car (process-lines notmuch-command "count" search)))\r
+>> @@ -496,12 +497,20 @@ (defun notmuch-hello-insert-buttons (searches)\r
+>> (widget-insert (make-string column-indent ? )))\r
+>> (let* ((name (plist-get elem :name))\r
+>> (query (plist-get elem :query))\r
+>> + (oldest-first (cond\r
+>> + ((eq (plist-get elem :sort-order) 'newest-first)\r
+>> + nil)\r
+>> + ((eq (plist-get elem :sort-order) 'oldest-first)\r
+>> + t)\r
+>> + (t\r
+>> + notmuch-search-oldest-first)))\r
+>\r
+> (case (plist-get elem :sort-order)\r
+> (newest-first nil)\r
+> (oldest-first t)\r
+> (otherwise notmuch-search-oldest-first))\r
+\r
+This is much better.\r
+\r
+>\r
+>> (msg-count (plist-get elem :count)))\r
+>> (widget-insert (format "%8s "\r
+>> (notmuch-hello-nice-number msg-count)))\r
+>> (widget-create 'push-button\r
+>> :notify #'notmuch-hello-widget-search\r
+>> :notmuch-search-terms query\r
+>> + :notmuch-search-oldest-first oldest-first\r
+>> name)\r
+>> (setq column-indent\r
+>> (1+ (max 0 (- column-width (length name)))))))\r
+>> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+>> index 8a12f91..8aa8cfc 100644\r
+>> --- a/emacs/notmuch-lib.el\r
+>> +++ b/emacs/notmuch-lib.el\r
+>> @@ -125,7 +125,12 @@ (define-widget 'notmuch-saved-search-plist 'list\r
+>> (group :format "%v" :inline t (const :format " Query: " :query) (string :format "%v")))\r
+>> (checklist :inline t\r
+>> :format "%v"\r
+>> - (group :format "%v" :inline t (const :format "Count-Query: " :count-query) (string :format "%v")))))\r
+>> + (group :format "%v" :inline t (const :format "Count-Query: " :count-query) (string :format "%v"))\r
+>> + (group :format "%v" :inline t (const :format "" :sort-order)\r
+>> + (choice :tag " Sort Order"\r
+>\r
+> Should there be a colon? (I haven't applied the patches and I'm\r
+> afraid this is beyond my mental implementation of define-widget!)\r
+\r
+I think it is OK without: since this is using :tag rather than :format\r
+the colon is supplied automatically.\r
+\r
+Many thanks\r
+\r
+Mark\r
+\r
+>\r
+>> + (const :tag "Default" nil)\r
+>> + (const :tag "Oldest-first" oldest-first)\r
+>> + (const :tag "Newest-first" newest-first))))))\r
+>> \r
+>> (defcustom notmuch-saved-searches '((:name "inbox" :query "tag:inbox")\r
+>> (:name "unread" :query "tag:unread"))\r
projects / notmuch-archives.git / commitdiff