Re: [PATCH 01/24] lib/message.cc: stale pointer bug

diff --git a/22/f40f5242c5fb2a0e51c6a3ca1c75ddfa22899c b/22/f40f5242c5fb2a0e51c6a3ca1c75ddfa22899c
new file mode 100644 (file)
index 0000000..de03cf8
--- /dev/null
+++ b/22/f40f5242c5fb2a0e51c6a3ca1c75ddfa22899c
@@ -0,0 +1,79 @@
+Return-Path: <Vladimir.Marek@Oracle.COM>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E2CD7431FBF\r
+       for <notmuch@notmuchmail.org>; Wed,  1 May 2013 14:45:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.299\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FammqTNWHFsk for <notmuch@notmuchmail.org>;\r
+       Wed,  1 May 2013 14:45:24 -0700 (PDT)\r
+Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A3C46431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  1 May 2013 14:45:24 -0700 (PDT)\r
+Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])\r
+       by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with\r
+       ESMTP id r41LjLm2030723\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\r
+       Wed, 1 May 2013 21:45:23 GMT\r
+Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86])\r
+       by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id\r
+       r41LjL1f007021\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);\r
+       Wed, 1 May 2013 21:45:22 GMT\r
+Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60])\r
+       by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id\r
+       r41LjKsp018420; Wed, 1 May 2013 21:45:21 GMT\r
+Received: from pub.cz.oracle.com (/10.163.101.122)\r
+       by default (Oracle Beehive Gateway v4.0)\r
+       with ESMTP ; Wed, 01 May 2013 14:45:20 -0700\r
+Date: Wed, 1 May 2013 23:43:24 +0200\r
+From: Vladimir Marek <Vladimir.Marek@Oracle.COM>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 01/24] lib/message.cc: stale pointer bug\r
+Message-ID: <20130501214324.GF19599@pub.cz.oracle.com>\r
+Mail-Followup-To: notmuch@notmuchmail.org,\r
+       Vladimir Marek <vlmarek@volny.cz>\r
+References: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+In-Reply-To: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Source-IP: acsinet21.oracle.com [141.146.126.237]\r
+Cc: Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 May 2013 21:45:31 -0000\r
+\r
+Uh, oh, it's patch 01/01 actually. There's 23 other patches waiting but\r
+will be submitted separately.\r
+\r
+> Xapian::TermIterator::operator* returns std::string which is destroyed\r
+> as soon as (*i).c_str() finishes. The remembered pointer 'term' then\r
+> references invalid memory.\r
+\r
+I reworded the comment and I changed the fix slightly.\r
+\r
+Thank you\r
+-- \r
+       Vlad\r