Re: [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work

diff --git a/37/249e17cb668364764cf6cea01625fbc1847d3f b/37/249e17cb668364764cf6cea01625fbc1847d3f
new file mode 100644 (file)
index 0000000..1475617
--- /dev/null
+++ b/37/249e17cb668364764cf6cea01625fbc1847d3f
@@ -0,0 +1,118 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B3954431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id frfdmXqvWdYZ for <notmuch@notmuchmail.org>;\r
+       Sat, 12 Apr 2014 03:50:09 -0700 (PDT)\r
+Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com\r
+ [74.125.83.43])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 4AB77431FAF   for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:09 -0700\r
+ (PDT)\r
+Received: by mail-ee0-f43.google.com with SMTP id e53so4894895eek.2\r
+       for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:05 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=YZ96Gf4DLF+X8lVbESyyBoU2U7lzYxdGnAwgmxhgYH8=;\r
+       b=UzbFNStOrgbVFyD9rHV8bK1PDXrntW0M7OxpaU8C2scOAxlw/sCSEA/kKVs+lUE7NZ\r
+       00MfSPHFCwmqnIbQRZgXDhiVZlsWd88tmYkrP8nkgN2jhBjaGeNViX28g+k95ax2u8cX\r
+       eyFgHfbWl8914y+RVq7k//xihoXrOlPHIRkXQIgxYkQx9eacZt+z+vjyaH+ssOk4ZVrE\r
+       MR1ODYj8KtgmTp23UZSPX2zP6oG5eFKCrXPawWtXzVhUpxt5jlDEe3BbfwXKNOf94LlI\r
+       LjBBQld15L2RxgsZgu4U2V1UiVeg7SbO1yp8iZdfTv0I4X0FOluEhsLyRORenYS933Bv\r
+       LcKQ==\r
+X-Gm-Message-State:\r
+ ALoCoQnhfN0jem9rxqZaH12pWGzEfFX/sqR7kx1gP9/F2x+WIesvujhX1Deq+GXE2dhNkMz55WET\r
+X-Received: by 10.14.251.204 with SMTP id b52mr36023968ees.36.1397299805056;\r
+       Sat, 12 Apr 2014 03:50:05 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91]) by mx.google.com with ESMTPSA id\r
+       q49sm24447573eem.34.2014.04.12.03.50.03 for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 12 Apr 2014 03:50:04 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted\r
+       saved   searches work\r
+In-Reply-To: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.17+187~gf1bfa36 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 12 Apr 2014 13:50:02 +0300\r
+Message-ID: <878ura7rfp.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 12 Apr 2014 10:50:16 -0000\r
+\r
+On Sat, 12 Apr 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> My recent changes to the saved search format broke the alphabetically\r
+> sorted saved sort option. This makes it work again.\r
+>\r
+> Also, since the saved-search list is no longer an alist change the\r
+> names in the sort function to avoid confusion.\r
+> ---\r
+> Thanks to Jani for pointing out the bug.\r
+\r
+Looks good, works for me, thanks for the fix.\r
+\r
+BR,\r
+Jani.\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>  emacs/notmuch-hello.el |    9 ++++++---\r
+>  1 file changed, 6 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index 4900a24..fca2bcc 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -39,9 +39,12 @@ (defcustom notmuch-show-empty-saved-searches nil\r
+>    :type 'boolean\r
+>    :group 'notmuch-hello)\r
+>  \r
+> -(defun notmuch-sort-saved-searches (alist)\r
+> -  "Generate an alphabetically sorted saved searches alist."\r
+> -  (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))\r
+> +(defun notmuch-sort-saved-searches (saved-searches)\r
+> +  "Generate an alphabetically sorted saved searches list."\r
+> +  (sort (copy-sequence saved-searches)\r
+> +    (lambda (a b)\r
+> +      (string< (notmuch-saved-search-get a :name)\r
+> +               (notmuch-saved-search-get b :name)))))\r
+>  \r
+>  (defcustom notmuch-saved-search-sort-function nil\r
+>    "Function used to sort the saved searches for the notmuch-hello view.\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r