Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

diff --git a/1f/b4022dcbaf4ce36628e9e6ba8f097bfd065703 b/1f/b4022dcbaf4ce36628e9e6ba8f097bfd065703
new file mode 100644 (file)
index 0000000..0ccda14
--- /dev/null
+++ b/1f/b4022dcbaf4ce36628e9e6ba8f097bfd065703
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 134EE431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 05:31:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NmZP1k8xP6Eg for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 05:31:17 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 72D76431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 05:31:17 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1WiNSa-00077a-7x; Thu, 08 May 2014 12:30:00 +0000\r
+Received: (nullmailer pid 27207 invoked by uid 1000); Thu, 08 May 2014\r
+       12:29:30 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h\r
+       with an underscore.\r
+In-Reply-To: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>\r
+References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 08 May 2014 21:29:30 +0900\r
+Message-ID: <87iopgv4gl.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 12:31:46 -0000\r
+\r
+Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+\r
+> An underscore should precede every function name in\r
+> lib/notmuch-private.h. \r
+ \r
+Is this a reference to notmuch coding style document, or something else?\r
+\r
+> This was not true and was noted by the failure of test\r
+> T360-symbol-hiding on Mac OS/X. This patch inserts an underscore\r
+> before each function name in lib/notmuch-private.h where the\r
+> underscore was missing and renames functions appropriately where they\r
+> are used.\r
+\r
+I'm not sure I understand the problem this patch is intended to solve.\r
+Is the problem that symbols are being inadvertantly exported? Or the\r
+test is wrong?  \r
+\r
+d\r