Re: [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local
authorDavid Bremner <david@tethera.net>
Tue, 25 Mar 2014 02:14:17 +0000 (23:14 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:00:57 +0000 (10:00 -0800)
c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0 [new file with mode: 0644]

diff --git a/c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0 b/c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0
new file mode 100644 (file)
index 0000000..35b79a5
--- /dev/null
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8C726431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Mar 2014 19:14:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TxqV8HIpIHQ3 for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Mar 2014 19:14:23 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6812F431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Mar 2014 19:14:23 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WSGse-0003Nh-H5; Mon, 24 Mar 2014 23:14:20 -0300\r
+Received: (nullmailer pid 13180 invoked by uid 1000); Tue, 25 Mar 2014\r
+       02:14:17 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] build: compute subdirectories from the presence of\r
+       Makefile.local\r
+In-Reply-To: <1395276484-22363-2-git-send-email-david@tethera.net>\r
+References: <1395276484-22363-1-git-send-email-david@tethera.net>\r
+       <1395276484-22363-2-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 24 Mar 2014 23:14:17 -0300\r
+Message-ID: <87d2hbhvnq.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 25 Mar 2014 02:14:30 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> This allows the fragile sed command in configure to be replaced with a somewhat\r
+> less fragile find command.\r
+> -subdirs = compat completion doc emacs lib parse-time-string \\r
+> -    performance-test util test test/test-databases\r
+> +subdirs = $(dir $(shell find . -mindepth 2 -name Makefile.local))\r
+\r
+I discovered a bug with this idea. There is actually an ordering\r
+dependency for the sub Makefiles; in particular the targets of\r
+test/Makefile.local use variables defined in lib/Makefile.local. I'll\r
+have to think if/how this can be salvaged.\r
+\r
+d\r