--- /dev/null
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 53C8D40DBD4\r
+ for <notmuch@notmuchmail.org>; Tue, 9 Nov 2010 15:39:48 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.9\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5\r
+ tests=[BAYES_00=-1.9] autolearn=unavailable\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id i46CDZFti5Mq for <notmuch@notmuchmail.org>;\r
+ Tue, 9 Nov 2010 15:39:35 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2FAF740DBD3\r
+ for <notmuch@notmuchmail.org>; Tue, 9 Nov 2010 15:39:35 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.4])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 2436E19F334D;\r
+ Wed, 10 Nov 2010 00:39:34 +0100 (CET)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+ by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+ port 10044)\r
+ with ESMTP id vEqg5nFhwAmv; Wed, 10 Nov 2010 00:39:32 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id DEE8819F334C;\r
+ Wed, 10 Nov 2010 00:39:32 +0100 (CET)\r
+Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])\r
+ (Authenticated sender: sojkam1)\r
+ by imap.feld.cvut.cz (Postfix) with ESMTPSA id 0E27FFA003;\r
+ Wed, 10 Nov 2010 00:39:31 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.72)\r
+ (envelope-from <sojkam1@fel.cvut.cz>)\r
+ id 1PFxml-0001JA-MA; Wed, 10 Nov 2010 00:39:31 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 0/4] Maildir synchronization\r
+In-Reply-To: <87oc9ykzae.fsf@yoom.home.cworth.org>\r
+References: <87tyk3vpxd.fsf@wsheee.2x.cz>\r
+ <1288560558-18915-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <877hgsrjau.fsf@yoom.home.cworth.org> <87d3qhq527.fsf@resox.2x.cz>\r
+ <874obrmww9.fsf@yoom.home.cworth.org>\r
+ <87iq066cbd.fsf@steelpick.2x.cz>\r
+ <87oc9ykzae.fsf@yoom.home.cworth.org>\r
+User-Agent: Notmuch/0.4-30-ga01dbf0 (http://notmuchmail.org) Emacs/23.2.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 10 Nov 2010 00:39:31 +0100\r
+Message-ID: <877hgm2hjg.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 09 Nov 2010 23:39:48 -0000\r
+\r
+On Tue, 09 Nov 2010, Carl Worth wrote:\r
+> The updating I've done here only goes as far as just before "Add a\r
+> message to new/ without info". And it looks like one change I made\r
+> inadvertently broke a later test, so it's expected that "Check that\r
+> removing info did not change tags" currently fails. [And this failure\r
+> shows what I don't like about test_expect_success---if we were using\r
+> test_expect_equal it would be trivial to see what problem I made\r
+> here.]\r
+\r
+Did you try ./maildyr-sync -v? In fact, this is what I don't like about\r
+test_begin_subtest. test_begin_subtest does not hide debug output that\r
+goes to stdout and should only be shown with -v. I admit that\r
+test_expect_success is not ideal though. Without -v, it should\r
+automatically show stdout when a test fails. I'll send patch for this in\r
+another mail.\r
+\r
+> \r
+> Finally, when going through these tests I saw:\r
+> \r
+> "Removing of unread tag should fail without cur/"\r
+> \r
+> And that's behavior I do not want. Adding and removing tags should be\r
+> reliable whether or not the maildir synchronization can succeed. In this\r
+> specific case, the right answer is probably to say that a directory\r
+> without "new" and "cur" is not a maildir so no synchronization should be\r
+> done.\r
+\r
+This only fails if the message is in */new and there is no */cur.\r
+\r
+> Notmuch does need to be able to support things like mh format still. Do\r
+> the current patches break that by doing maildir-style renaming in\r
+> non-maildir directories?\r
+\r
+I do not know if MH format has something special or it is just plain\r
+files in plain directories. If the latter, the synchronzation should\r
+work unless one of the directories is named 'new'. See the tests with\r
+fakenew directory [fakenew is probably not the most obvious name for a\r
+simple non-maildir directory].\r
+\r
+> If so, we'll need to fix that as well. And that might require an\r
+> "is_maildir" term to be stored for directory documents in the\r
+> database.\r
+> \r
+> Again, that's something I can help with.\r
+\r
+If you think that what we have now is not sufficient, I'd need some help\r
+with this.\r
+\r
+-Michal\r
+\r
+P.S. Because of my work on test suite, I didn't do any additional tests\r
+for maildir synchronization, so maybe tomorrow :-(\r
projects / notmuch-archives.git / commitdiff