Re: [RFC] Split notmuch_database_close into two functions

diff --git a/32/8f46a67ef933a791ff6fdc942aeb34278f23f0 b/32/8f46a67ef933a791ff6fdc942aeb34278f23f0
new file mode 100644 (file)
index 0000000..4a14841
--- /dev/null
+++ b/32/8f46a67ef933a791ff6fdc942aeb34278f23f0
@@ -0,0 +1,72 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B103F431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Mar 2012 02:07:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DCwLeCnCjecW for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Mar 2012 02:07:24 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 27A9E431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Mar 2012 02:07:24 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 26E9768055; Sat, 24 Mar 2012 11:07:22 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC] Split notmuch_database_close into two functions\r
+In-Reply-To:\r
+ <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+References: <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>User-Agent: Notmuch/0.12+70~g598bf0a  (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 24 Mar 2012 11:07:22 +0200\r
+Message-ID: <m2k42aicz9.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Mar 2012 09:07:24 -0000\r
+\r
+Justus Winter <4winter@informatik.uni-hamburg.de> writes:\r
+\r
+> I propose to split the function notmuch_database_close into\r
+> notmuch_database_close and notmuch_database_destroy so that long\r
+> running processes like alot can close the database while still using\r
+> data obtained from queries to that database.\r
+>\r
+> I've updated the tools, the go, ruby and python bindings to use\r
+> notmuch_database_destroy instead of notmuch_database_close to destroy\r
+> database objects.\r
+\r
+This looks like a good idea. grep _destroy *.c outputs plenty of\r
+other matches so this is not a new term here. I wonder what (backward)\r
+compability issues there are, though.\r
+\r
+In message id:"1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de"\r
+there was typo in comment: notmuch_database_destroyed ?\r
+\r
+>\r
+> Cheers,\r
+> Justus\r
+\r
+Tomi\r