Re: [PATCH 2/2] emacs: Fix "no such file or directory" error

diff --git a/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11 b/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11
new file mode 100644 (file)
index 0000000..c8b2692
--- /dev/null
+++ b/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3891A431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 23:21:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ovV5W3NEzFhl for <notmuch@notmuchmail.org>;\r
+       Sun,  9 Jun 2013 23:21:41 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8CAE1431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 23:21:41 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 6E745100044;\r
+       Mon, 10 Jun 2013 09:21:29 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>,\r
+       Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error\r
+In-Reply-To: <20130610021534.GB22196@mit.edu>\r
+References: <1370753138-15021-1-git-send-email-amdragon@mit.edu>\r
+       <1370753138-15021-3-git-send-email-amdragon@mit.edu>\r
+       <87hah7od8b.fsf@qmul.ac.uk> <20130610021534.GB22196@mit.edu>\r
+User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 10 Jun 2013 09:21:29 +0300\r
+Message-ID: <m27gi2fpue.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Jun 2013 06:21:53 -0000\r
+\r
+On Mon, Jun 10 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Quoth Mark Walters on Jun 09 at 10:16 am:\r
+>> \r
+>> Both of these patches look good to me +1. I was able to reproduce both\r
+>> bugs pretty reliably (the first one always unless masked by the second\r
+>> one which occurred about half the time). With these patches I cannot\r
+>> trigger either. Also all tests pass.\r
+>> \r
+>> My only tiny concern is I couldn't find any documentation on whether the\r
+>> return value of the filter-function matters at all. Austin's original\r
+>> fix (via irc) returned t and this returns nil in the failing case (i.e.,\r
+>> when results-buf is dead).\r
+>\r
+> Mm, interesting.  To be fair, my choice of "t" for the original fix\r
+> was completely arbitrary.  I think you're right that the Emacs\r
+> documentation doesn't have anything to say about the return values of\r
+> filter functions.  Furthermore, the example filter functions they give\r
+> don't have meaningful return values, so I'm pretty sure this is safe.\r
+> Also the code that calls the filter discards its result.\r
+\r
+I also looked this a bit yesterday evening. For example this page\r
+\r
+http://www.gnu.org/software/emacs/manual/html_node/elisp/Filter-Functions.html\r
+\r
+discusses only about catching thrown errors -- i.e. no mention about\r
+filter function return values. From that I'd draw a conclusion that \r
+most probably the return value of filter function is not used for anything.\r
+\r
+... and the patch looks good. +1 (removing needs-review)\r
+\r
+Tomi\r
+\r