Re: [Patch v2 0/3] contrib: pick: remove an unused variable
authorTomi Ollila <tomi.ollila@iki.fi>
Mon, 2 Sep 2013 15:17:18 +0000 (18:17 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:56:49 +0000 (09:56 -0800)
8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2 [new file with mode: 0644]

diff --git a/8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2 b/8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2
new file mode 100644 (file)
index 0000000..b800ae1
--- /dev/null
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 49C34431FC7\r
+       for <notmuch@notmuchmail.org>; Mon,  2 Sep 2013 08:17:33 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FAiYMsk-O+e3 for <notmuch@notmuchmail.org>;\r
+       Mon,  2 Sep 2013 08:17:26 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BE69A431FC3\r
+       for <notmuch@notmuchmail.org>; Mon,  2 Sep 2013 08:17:26 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 8EFC910005E;\r
+       Mon,  2 Sep 2013 18:17:18 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 0/3] contrib: pick: remove an unused variable\r
+In-Reply-To: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+45~g1eaad39 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 02 Sep 2013 18:17:18 +0300\r
+Message-ID: <m2hae3uubl.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 02 Sep 2013 15:17:33 -0000\r
+\r
+On Tue, Aug 27 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> v2 of this series is at\r
+> id:1377460214-4795-1-git-send-email-markwalters1009@gmail.com\r
+>\r
+> v2 had a bug on refresh view (which I should have tested more). The\r
+> main pick view only worked by fluke as the initial call to pick-worker\r
+> was inside a let binding.\r
+>\r
+> This version fixes the bug, moves the call to pick-worker outside the\r
+> let binding (so the bug would have shown up sooner) and also adds a\r
+> test for refresh view.\r
+>\r
+> It is also rebased on top of\r
+> id:1377547043-17584-1-git-send-email-markwalters1009@gmail.com so that\r
+> series should be applied first.\r
+\r
+Looks Good, tests pass. +1\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+\r
+>\r
+>\r
+> Mark Walters (3):\r
+>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name\r
+>   contrib: pick: add docstring for notmuch-pick-worker\r
+>   contrib: pick: test: refresh view\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   29 +++++++++++++----------------\r
+>  contrib/notmuch-pick/test/emacs-pick |   11 +++++++++++\r
+>  2 files changed, 24 insertions(+), 16 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+>\r
+\r
+-- \r
+uussigu\r